New issue
Advanced search Search tips

Issue 712892 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
EstimatedDays: ----
NextAction: ----
OS: Android , and
Pri: 1
Type: Bug



Sign in to add a comment

Introduce counterparts to compare the bandwidth of parallel download

Project Member Reported by qin...@chromium.org, Apr 18 2017

Issue description

For parallel download, we need to study the bandwidth when parallel flag is disabled/enabled.

To do a fair comparison, we need to calculate the bandwidth for downloads that satisfies parallel requirements.
 

Comment 1 by qin...@chromium.org, Apr 18 2017

Labels: -Pri-3 Pri-1
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2269e30d4ea0874704bfbd4021c087ba960e7ea5

commit 2269e30d4ea0874704bfbd4021c087ba960e7ea5
Author: qinmin <qinmin@chromium.org>
Date: Thu Apr 20 21:04:52 2017

Add new UMA stats for parallelizable download

To study the effectiveness of parallel download,
we want to compare the bandwidth if parallel downloads are not parallelized.
Because parallel download has requirements on file size, so comparing with all
other downloads is be fair.
This CL records the UMA metrics for downloads that satisfy the requirement
of parallel download, while don't use parallel requests.

BUG=644352, 712892 

Review-Url: https://codereview.chromium.org/2823273004
Cr-Commit-Position: refs/heads/master@{#466128}

[modify] https://crrev.com/2269e30d4ea0874704bfbd4021c087ba960e7ea5/content/browser/download/download_browsertest.cc
[modify] https://crrev.com/2269e30d4ea0874704bfbd4021c087ba960e7ea5/content/browser/download/download_file.h
[modify] https://crrev.com/2269e30d4ea0874704bfbd4021c087ba960e7ea5/content/browser/download/download_file_impl.cc
[modify] https://crrev.com/2269e30d4ea0874704bfbd4021c087ba960e7ea5/content/browser/download/download_file_impl.h
[modify] https://crrev.com/2269e30d4ea0874704bfbd4021c087ba960e7ea5/content/browser/download/download_file_unittest.cc
[modify] https://crrev.com/2269e30d4ea0874704bfbd4021c087ba960e7ea5/content/browser/download/download_item_impl.cc
[modify] https://crrev.com/2269e30d4ea0874704bfbd4021c087ba960e7ea5/content/browser/download/download_item_impl_unittest.cc
[modify] https://crrev.com/2269e30d4ea0874704bfbd4021c087ba960e7ea5/content/browser/download/download_job.cc
[modify] https://crrev.com/2269e30d4ea0874704bfbd4021c087ba960e7ea5/content/browser/download/download_job.h
[modify] https://crrev.com/2269e30d4ea0874704bfbd4021c087ba960e7ea5/content/browser/download/download_job_factory.cc
[modify] https://crrev.com/2269e30d4ea0874704bfbd4021c087ba960e7ea5/content/browser/download/download_job_impl.cc
[modify] https://crrev.com/2269e30d4ea0874704bfbd4021c087ba960e7ea5/content/browser/download/download_job_impl.h
[modify] https://crrev.com/2269e30d4ea0874704bfbd4021c087ba960e7ea5/content/browser/download/download_stats.cc
[modify] https://crrev.com/2269e30d4ea0874704bfbd4021c087ba960e7ea5/content/browser/download/download_stats.h
[modify] https://crrev.com/2269e30d4ea0874704bfbd4021c087ba960e7ea5/content/browser/download/mock_download_file.cc
[modify] https://crrev.com/2269e30d4ea0874704bfbd4021c087ba960e7ea5/content/browser/download/mock_download_file.h
[modify] https://crrev.com/2269e30d4ea0874704bfbd4021c087ba960e7ea5/content/browser/download/parallel_download_job.cc
[modify] https://crrev.com/2269e30d4ea0874704bfbd4021c087ba960e7ea5/content/browser/download/parallel_download_job.h
[modify] https://crrev.com/2269e30d4ea0874704bfbd4021c087ba960e7ea5/content/browser/download/parallel_download_utils.cc
[modify] https://crrev.com/2269e30d4ea0874704bfbd4021c087ba960e7ea5/content/browser/download/parallel_download_utils.h
[modify] https://crrev.com/2269e30d4ea0874704bfbd4021c087ba960e7ea5/content/public/test/test_file_error_injector.cc
[modify] https://crrev.com/2269e30d4ea0874704bfbd4021c087ba960e7ea5/tools/metrics/histograms/histograms.xml

Comment 3 by qin...@chromium.org, Apr 20 2017

Labels: Merge-Request-59 M-59
Owner: qin...@chromium.org
Status: Started (was: Untriaged)
Please tag with applicable OSs.  Thanks.

Comment 5 by qin...@chromium.org, Apr 21 2017

Labels: os-and OS-Android
Project Member

Comment 6 by sheriffbot@chromium.org, Apr 21 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 24 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7823c3140937e3fbfdc8eee48dfd780707b78e3

commit f7823c3140937e3fbfdc8eee48dfd780707b78e3
Author: Min Qin <qinmin@chromium.org>
Date: Mon Apr 24 17:44:06 2017

Add new UMA stats for parallelizable download

To study the effectiveness of parallel download,
we want to compare the bandwidth if parallel downloads are not parallelized.
Because parallel download has requirements on file size, so comparing with all
other downloads is be fair.
This CL records the UMA metrics for downloads that satisfy the requirement
of parallel download, while don't use parallel requests.

BUG=644352, 712892 
TBR=dtrainor@chromium.org,alexmos@chromium.org,isherman@chromium.org

Review-Url: https://codereview.chromium.org/2823273004
Cr-Commit-Position: refs/heads/master@{#466128}
(cherry picked from commit 2269e30d4ea0874704bfbd4021c087ba960e7ea5)

Review-Url: https://codereview.chromium.org/2839693002 .
Cr-Commit-Position: refs/branch-heads/3071@{#168}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/f7823c3140937e3fbfdc8eee48dfd780707b78e3/content/browser/download/download_browsertest.cc
[modify] https://crrev.com/f7823c3140937e3fbfdc8eee48dfd780707b78e3/content/browser/download/download_file.h
[modify] https://crrev.com/f7823c3140937e3fbfdc8eee48dfd780707b78e3/content/browser/download/download_file_impl.cc
[modify] https://crrev.com/f7823c3140937e3fbfdc8eee48dfd780707b78e3/content/browser/download/download_file_impl.h
[modify] https://crrev.com/f7823c3140937e3fbfdc8eee48dfd780707b78e3/content/browser/download/download_file_unittest.cc
[modify] https://crrev.com/f7823c3140937e3fbfdc8eee48dfd780707b78e3/content/browser/download/download_item_impl.cc
[modify] https://crrev.com/f7823c3140937e3fbfdc8eee48dfd780707b78e3/content/browser/download/download_item_impl_unittest.cc
[modify] https://crrev.com/f7823c3140937e3fbfdc8eee48dfd780707b78e3/content/browser/download/download_job.cc
[modify] https://crrev.com/f7823c3140937e3fbfdc8eee48dfd780707b78e3/content/browser/download/download_job.h
[modify] https://crrev.com/f7823c3140937e3fbfdc8eee48dfd780707b78e3/content/browser/download/download_job_factory.cc
[modify] https://crrev.com/f7823c3140937e3fbfdc8eee48dfd780707b78e3/content/browser/download/download_job_impl.cc
[modify] https://crrev.com/f7823c3140937e3fbfdc8eee48dfd780707b78e3/content/browser/download/download_job_impl.h
[modify] https://crrev.com/f7823c3140937e3fbfdc8eee48dfd780707b78e3/content/browser/download/download_stats.cc
[modify] https://crrev.com/f7823c3140937e3fbfdc8eee48dfd780707b78e3/content/browser/download/download_stats.h
[modify] https://crrev.com/f7823c3140937e3fbfdc8eee48dfd780707b78e3/content/browser/download/mock_download_file.cc
[modify] https://crrev.com/f7823c3140937e3fbfdc8eee48dfd780707b78e3/content/browser/download/mock_download_file.h
[modify] https://crrev.com/f7823c3140937e3fbfdc8eee48dfd780707b78e3/content/browser/download/parallel_download_job.cc
[modify] https://crrev.com/f7823c3140937e3fbfdc8eee48dfd780707b78e3/content/browser/download/parallel_download_job.h
[modify] https://crrev.com/f7823c3140937e3fbfdc8eee48dfd780707b78e3/content/browser/download/parallel_download_utils.cc
[modify] https://crrev.com/f7823c3140937e3fbfdc8eee48dfd780707b78e3/content/browser/download/parallel_download_utils.h
[modify] https://crrev.com/f7823c3140937e3fbfdc8eee48dfd780707b78e3/content/public/test/test_file_error_injector.cc
[modify] https://crrev.com/f7823c3140937e3fbfdc8eee48dfd780707b78e3/tools/metrics/histograms/histograms.xml

Comment 8 by qin...@chromium.org, Apr 24 2017

Status: Fixed (was: Started)

Sign in to add a comment