New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 712888 link

Starred by 1 user
Status: Fixed
Owner:
qyears...@chromium.org
Closed: Apr 2017
Cc:
█ ortuno@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

WPT importer parses the wrong owners from W3CImportExpectations sometimes

Project Member Reported by qyears...@chromium.org, Apr 18 2017 
From chat:

> Me and scheib are owners of only wpt/bluetooth but we were added as
> reviewers to [1] because of common. I think the problem is that common
> has the "Owners" comment but no actual owners[2] and the script is just
> reusing the previous owners.

[1] https://chromium-review.googlesource.com/c/476770/
[2] https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/W3CImportExpectations?type=cs&q=ortuno&sq=package:chromium&l=39
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54d7e3050af7ebb57aa7cd99cef14037db03f3bf

commit 54d7e3050af7ebb57aa7cd99cef14037db03f3bf
Author: qyearsley <qyearsley@chromium.org>
Date: Thu Apr 20 00:59:24 2017

Fix bug in webkitpy/w3c/directory_owners_extractor.py

Specifically, in cases like:

 # Owners: foo@chromium.org
 # directory1 [ Pass ]
 # Owners: nobody
 # directory2 [ Pass ]

the function lines_to_owner_map was associating directory2 with
foo@chromium.org even though owners should have been reset in this case.

BUG= 712888 

Review-Url: https://codereview.chromium.org/2827673005
Cr-Commit-Position: refs/heads/master@{#465838}

[modify] https://crrev.com/54d7e3050af7ebb57aa7cd99cef14037db03f3bf/third_party/WebKit/Tools/Scripts/webkitpy/w3c/directory_owners_extractor.py
[modify] https://crrev.com/54d7e3050af7ebb57aa7cd99cef14037db03f3bf/third_party/WebKit/Tools/Scripts/webkitpy/w3c/directory_owners_extractor_unittest.py

Comment 2 by qyears...@chromium.org, Apr 21 2017

Status: Fixed (was: Assigned)

Comment 3 by foolip@chromium.org, Jul 3 2017

Components: Blink>Infra>Ecosystem

Comment 4 by foolip@chromium.org, Jul 3 2017

Components: -Blink>Infra>Predictability
►

Sign in to add a comment