New issue
Advanced search Search tips

Issue 712887 link

Starred by 1 user
Status: Fixed
Owner:
wutao@chromium.org
Closed: May 2017
Cc:
afakhry@chromium.org
jdufault@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

HandleShowStylusTools crashes at desktop ChromeOS UI and shows stylus tools on device does not have stylus.

Project Member Reported by wutao@chromium.org, Apr 18 2017 
Chrome Version: (60.0.3075.0)
OS: (9439.0.0)

What steps will reproduce the problem?
There are two problems. Try to describe at the same time.
(1) Run chrome without any stylus flags on desktop / or any chromebook without stylus, such as ELM.
(2) Login
(3) Press "SHIFT+ALT+p".

What is the expected result?
Should not do any thing because without stylus flags or without stylus on the ChromeBook.

What happens instead?
Crash on desktop / The stylus tools is shown on device without stylus.

Comment 1 by wutao@chromium.org, Apr 19 2017 

Uploaded a cl to fix this: https://codereview.chromium.org/2825383003/
Project Member

Comment 2 by bugdroid1@chromium.org, May 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53e9c2e81bf4fe7d0f6bcaebca0c717b19430313

commit 53e9c2e81bf4fe7d0f6bcaebca0c717b19430313
Author: wutao <wutao@chromium.org>
Date: Thu May 04 19:19:29 2017

Fix stylus tools palette.

HandleShowStylusTools crashes at desktop ChromeOS UI and shows stylus
tools on device does not have stylus. Adding more checks when we should
HandleShowStylusTools and when to AddPaletteTray.

BUG= 712887 ,  717674 ,  717422 
TEST=Manual && AboutFlagsHistogramTest.CheckHistograms

Review-Url: https://codereview.chromium.org/2825383003
Cr-Commit-Position: refs/heads/master@{#469418}

[modify] https://crrev.com/53e9c2e81bf4fe7d0f6bcaebca0c717b19430313/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/53e9c2e81bf4fe7d0f6bcaebca0c717b19430313/ash/ash_switches.cc
[modify] https://crrev.com/53e9c2e81bf4fe7d0f6bcaebca0c717b19430313/ash/ash_switches.h
[modify] https://crrev.com/53e9c2e81bf4fe7d0f6bcaebca0c717b19430313/ash/system/palette/palette_tray.cc
[modify] https://crrev.com/53e9c2e81bf4fe7d0f6bcaebca0c717b19430313/ash/system/palette/palette_tray.h
[modify] https://crrev.com/53e9c2e81bf4fe7d0f6bcaebca0c717b19430313/ash/system/palette/palette_utils.cc
[modify] https://crrev.com/53e9c2e81bf4fe7d0f6bcaebca0c717b19430313/ash/system/palette/palette_utils.h
[modify] https://crrev.com/53e9c2e81bf4fe7d0f6bcaebca0c717b19430313/ash/system/status_area_widget.cc
[modify] https://crrev.com/53e9c2e81bf4fe7d0f6bcaebca0c717b19430313/ash/system/status_area_widget_unittest.cc
[modify] https://crrev.com/53e9c2e81bf4fe7d0f6bcaebca0c717b19430313/chrome/browser/about_flags.cc
[modify] https://crrev.com/53e9c2e81bf4fe7d0f6bcaebca0c717b19430313/chrome/browser/chromeos/login/chrome_restart_request.cc
[modify] https://crrev.com/53e9c2e81bf4fe7d0f6bcaebca0c717b19430313/chrome/browser/chromeos/note_taking_helper_unittest.cc
[modify] https://crrev.com/53e9c2e81bf4fe7d0f6bcaebca0c717b19430313/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/53e9c2e81bf4fe7d0f6bcaebca0c717b19430313/ui/events/devices/input_device.cc
[modify] https://crrev.com/53e9c2e81bf4fe7d0f6bcaebca0c717b19430313/ui/events/devices/touchscreen_device.cc
[modify] https://crrev.com/53e9c2e81bf4fe7d0f6bcaebca0c717b19430313/ui/events/devices/touchscreen_device.h

Comment 3 by wutao@chromium.org, May 16 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment