New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 712886 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 711831



Sign in to add a comment

[Findit] consolidate flags for rerun into one

Project Member Reported by chanli@chromium.org, Apr 18 2017

Issue description

Right now to rerun an analysis, we need to enter 3 flags: force, force_try_job and build_completed.

Consolidate these 3 flags into one (force) and check if build is completed at Findit side.
 

Comment 1 by chanli@chromium.org, Apr 18 2017

Blocking: 711831
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/6917c1134ce58e6961a7d3111416795984383d22

commit 6917c1134ce58e6961a7d3111416795984383d22
Author: Chan <chanli@chromium.org>
Date: Thu Apr 20 19:08:47 2017

[Findit] Consolidate flags when rerun an analysis

Consolidate the 3 flags when rerun an analysis (force, force_try_job and build_completed) to one
since now try jobs are stable.

Check if build completed instead of passing a falg.

Bug:  712886 
Change-Id: I5f4da99b741c39ea951deeeec5a12a456849d0fc
Reviewed-on: https://chromium-review.googlesource.com/482469
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>

[modify] https://crrev.com/6917c1134ce58e6961a7d3111416795984383d22/appengine/findit/handlers/test/process_failure_analysis_requests_test.py
[modify] https://crrev.com/6917c1134ce58e6961a7d3111416795984383d22/appengine/findit/waterfall/test/build_failure_analysis_pipelines_test.py
[modify] https://crrev.com/6917c1134ce58e6961a7d3111416795984383d22/appengine/findit/waterfall/build_failure_analysis_pipelines.py
[modify] https://crrev.com/6917c1134ce58e6961a7d3111416795984383d22/appengine/findit/handlers/process_failure_analysis_requests.py
[modify] https://crrev.com/6917c1134ce58e6961a7d3111416795984383d22/appengine/findit/waterfall/trigger_swarming_tasks_pipeline.py
[modify] https://crrev.com/6917c1134ce58e6961a7d3111416795984383d22/appengine/findit/waterfall/analyze_build_failure_pipeline.py
[modify] https://crrev.com/6917c1134ce58e6961a7d3111416795984383d22/appengine/findit/waterfall/test/trigger_swarming_tasks_pipeline_test.py
[modify] https://crrev.com/6917c1134ce58e6961a7d3111416795984383d22/appengine/findit/handlers/build_failure.py
[modify] https://crrev.com/6917c1134ce58e6961a7d3111416795984383d22/appengine/findit/handlers/test/build_failure_test.py

Comment 3 by chanli@chromium.org, Apr 24 2017

Status: Fixed (was: Assigned)

Sign in to add a comment