New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 712880 link

Starred by 0 users
Status: Fixed
Owner:
sammiequon@chromium.org
Closed: Apr 2017
Cc:
█ xiaoyinh@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Fingerprint list tests are incorrect.

Project Member Reported by sammiequon@chromium.org, Apr 18 2017 
Thanks to xiaoyinh@ for noticing that some of the 'getFingerprintsList' expectations are passing when they shouldn't. This is because a previous 'getFingerprintsList' was called and put into the resolver map.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/786ed37e758793e92b323bcad36fad924ca305ad

commit 786ed37e758793e92b323bcad36fad924ca305ad
Author: sammiequon <sammiequon@chromium.org>
Date: Wed Apr 19 16:56:54 2017

md-settings: Fix fingerprint list tests.

Settings fingerprint list tests do not wait for the method to be called before procedding if the method has been called previously. Fix this by resetting the promise resolver each time the method is called, if it is called again later in the test.

TEST=browser_tests --gtest_filter="CrSettingsFingerprintListTest.*"
BUG= 712880 

Review-Url: https://codereview.chromium.org/2821133005
Cr-Commit-Position: refs/heads/master@{#465639}

[modify] https://crrev.com/786ed37e758793e92b323bcad36fad924ca305ad/chrome/test/data/webui/settings/fingerprint_browsertest_chromeos.js

Comment 2 by sammiequon@chromium.org, Apr 19 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment