New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 712876 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature



Sign in to add a comment

Network products should stripe entire row based on the classification of product

Project Member Reported by allada@chromium.org, Apr 18 2017

Issue description

see title.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d95cd94f4cd59f9ab6603f0cde95d32ecdbed77

commit 3d95cd94f4cd59f9ab6603f0cde95d32ecdbed77
Author: allada <allada@chromium.org>
Date: Thu Apr 20 02:25:06 2017

[Devtools] Network waterfall and grid rows feed bg color from same place

Makes network waterfall canvas now feed it's stripe colors from the node
itself rather than deriving it's colors from hard codded property
conditions.

We also removed css background color resolvers.

R=dgozman
BUG= 712876 

Review-Url: https://codereview.chromium.org/2827843002
Cr-Commit-Position: refs/heads/master@{#465868}

[modify] https://crrev.com/3d95cd94f4cd59f9ab6603f0cde95d32ecdbed77/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
[modify] https://crrev.com/3d95cd94f4cd59f9ab6603f0cde95d32ecdbed77/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
[modify] https://crrev.com/3d95cd94f4cd59f9ab6603f0cde95d32ecdbed77/third_party/WebKit/Source/devtools/front_end/network/networkLogView.css

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ded9a228e452e84df5aa818e0c8f67c72ff971dc

commit ded9a228e452e84df5aa818e0c8f67c72ff971dc
Author: allada <allada@chromium.org>
Date: Thu Apr 20 20:29:23 2017

[Devtools] Added product classification colorize rows to network panel

Adds colorizing of network resource to network panel under experiments.

See: http://imgur.com/a/IoMrC

R=pfeldman,dgozman
BUG= 712876 

Review-Url: https://codereview.chromium.org/2823903004
Cr-Commit-Position: refs/heads/master@{#466112}

[modify] https://crrev.com/ded9a228e452e84df5aa818e0c8f67c72ff971dc/third_party/WebKit/Source/devtools/front_end/network_group_lookup/NetworkProductGroupLookup.js

Comment 3 by allada@chromium.org, Apr 28 2017

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56637492051aec80a5023fc0bd8314c0143241db

commit 56637492051aec80a5023fc0bd8314c0143241db
Author: allada <allada@chromium.org>
Date: Sat Apr 29 01:14:52 2017

[Devtools] New structure and colorize rows for network products

Refactored the way the dependency chain is going for the products
module. We now have a shared module that is bundled and can be used to
resolve things like frame and product for url.

We are also adding background coloring to network rows.

R=pfeldman
BUG= 712876 

Review-Url: https://codereview.chromium.org/2839273003
Cr-Commit-Position: refs/heads/master@{#468203}

[modify] https://crrev.com/56637492051aec80a5023fc0bd8314c0143241db/third_party/WebKit/LayoutTests/inspector/initial-modules-load-expected.txt
[modify] https://crrev.com/56637492051aec80a5023fc0bd8314c0143241db/third_party/WebKit/LayoutTests/inspector/sha1.html
[modify] https://crrev.com/56637492051aec80a5023fc0bd8314c0143241db/third_party/WebKit/Source/devtools/BUILD.gn
[modify] https://crrev.com/56637492051aec80a5023fc0bd8314c0143241db/third_party/WebKit/Source/devtools/front_end/inspector.json
[modify] https://crrev.com/56637492051aec80a5023fc0bd8314c0143241db/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
[add] https://crrev.com/56637492051aec80a5023fc0bd8314c0143241db/third_party/WebKit/Source/devtools/front_end/network/NetworkGroupers.js
[modify] https://crrev.com/56637492051aec80a5023fc0bd8314c0143241db/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
[modify] https://crrev.com/56637492051aec80a5023fc0bd8314c0143241db/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
[modify] https://crrev.com/56637492051aec80a5023fc0bd8314c0143241db/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js
[modify] https://crrev.com/56637492051aec80a5023fc0bd8314c0143241db/third_party/WebKit/Source/devtools/front_end/network/module.json
[modify] https://crrev.com/56637492051aec80a5023fc0bd8314c0143241db/third_party/WebKit/Source/devtools/front_end/network/networkLogView.css
[delete] https://crrev.com/86ca67f5423cdb1e2ef6f193e2eebdb0abf83ab0/third_party/WebKit/Source/devtools/front_end/network_group_lookup/NetworkProductGroupLookup.js
[delete] https://crrev.com/86ca67f5423cdb1e2ef6f193e2eebdb0abf83ab0/third_party/WebKit/Source/devtools/front_end/network_group_lookup/module.json
[delete] https://crrev.com/86ca67f5423cdb1e2ef6f193e2eebdb0abf83ab0/third_party/WebKit/Source/devtools/front_end/product_registry/ProductNameForURL.js
[add] https://crrev.com/56637492051aec80a5023fc0bd8314c0143241db/third_party/WebKit/Source/devtools/front_end/product_registry/ProductRegistry.js
[modify] https://crrev.com/56637492051aec80a5023fc0bd8314c0143241db/third_party/WebKit/Source/devtools/front_end/product_registry/module.json
[rename] https://crrev.com/56637492051aec80a5023fc0bd8314c0143241db/third_party/WebKit/Source/devtools/front_end/product_registry_impl/ProductRegistryData.js
[add] https://crrev.com/56637492051aec80a5023fc0bd8314c0143241db/third_party/WebKit/Source/devtools/front_end/product_registry_impl/ProductRegistryImpl.js
[add] https://crrev.com/56637492051aec80a5023fc0bd8314c0143241db/third_party/WebKit/Source/devtools/front_end/product_registry_impl/module.json
[rename] https://crrev.com/56637492051aec80a5023fc0bd8314c0143241db/third_party/WebKit/Source/devtools/front_end/product_registry_impl/sha1/README.chromium
[rename] https://crrev.com/56637492051aec80a5023fc0bd8314c0143241db/third_party/WebKit/Source/devtools/front_end/product_registry_impl/sha1/sha1.js

Sign in to add a comment