"MojoDOMStorageBrowserTest.PRE_DataPersists" is flaky |
|||
Issue description"MojoDOMStorageBrowserTest.PRE_DataPersists" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyNQsSBUZsYWtlIipNb2pvRE9NU3RvcmFnZUJyb3dzZXJUZXN0LlBSRV9EYXRhUGVyc2lzdHMM. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs This flaky test/step was previously tracked in issue 692885 .
,
Apr 18 2017
Hmm yeah, thanks. Actually looks like this particular failure mode has always existed, I just somehow overlooked it/only fixed a different failure mode. Odd that it only seems to be failing this way on mac. I'll see if I can figure out what is going on/why destroying the DB thread fails...
,
Apr 18 2017
,
Apr 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17e49b087759887c2ebe54950ab5efdf45472fee commit 17e49b087759887c2ebe54950ab5efdf45472fee Author: mek <mek@chromium.org> Date: Wed Apr 19 17:08:57 2017 Disable several flaky mojo localstorage tests on Mac. Somehow sometimes browser shutdown crashes on shutting down the DB thread for these tests on mac. BUG= 712872 Review-Url: https://codereview.chromium.org/2820343003 Cr-Commit-Position: refs/heads/master@{#465644} [modify] https://crrev.com/17e49b087759887c2ebe54950ab5efdf45472fee/content/browser/dom_storage/dom_storage_browsertest.cc
,
May 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17399e67ce617b8936b5088dba92abb92b0cb8ee commit 17399e67ce617b8936b5088dba92abb92b0cb8ee Author: mek <mek@chromium.org> Date: Tue May 09 03:51:20 2017 Fix possible deadlock during shutdown by not using the FILE thread. The leveldb service needs to be able to call code in the file service, even during browser shutdown. If the file service runs on the file thread, this will fail, leading to deadlock/timeout. Instead move the file service to a new SingleThreadTaskRunner managed by the task scheduler. Also re-enable tests that hopefully should be fixed by this. BUG= 712872 BUG= 586194 Review-Url: https://codereview.chromium.org/2852333004 Cr-Commit-Position: refs/heads/master@{#470169} [modify] https://crrev.com/17399e67ce617b8936b5088dba92abb92b0cb8ee/content/browser/browser_context.cc [modify] https://crrev.com/17399e67ce617b8936b5088dba92abb92b0cb8ee/content/browser/dom_storage/dom_storage_browsertest.cc
,
Jun 7 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by rogerm@chromium.org
, Apr 18 2017