New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 712871 link

Starred by 3 users
Status: Fixed
Owner:
robliao@chromium.org
Closed: Oct 2017
Cc:
█ st...@zanderz.com
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

screen work_area not updated on WM_SETTINGCHANGE / SPI_SETWORKAREA

Reported by st...@zanderz.com, Apr 18 2017 
Chrome Version       : 56.0.2924.87
URLs (if applicable) : 
Other browsers tested:
  Add OK or FAIL after other browsers where you have tested this issue:
     Safari: PASS/FAIL (Version)
    Firefox: PASS/FAIL (Version)
         IE: PASS/FAIL (Version)

What steps will reproduce the problem?
(1) get atom::api::Screen::GetDisplayNearestPoint().work_area()
(2) change location of Windows taskbar in Windows 10
(3) repeat step (1)

What is the expected result?
Resulting work area rect should be different, reflecting new task bar location

What happens instead?
Work area rect still shows previous value

Please provide any additional information below. Attach a screenshot if
possible.

Possible fix could be to change display::win::ScreenWin::OnWndProc(), at 
ui\display\win\screen_win.cc, to handle the case when (message == WM_SETTINGCHANGE && wparam == SPI_SETWORKAREA)

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.
Project Member

Comment 1 by bugdroid1@chromium.org, May 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebd3740c435c3e5ff370b87668ef9001385507c1

commit ebd3740c435c3e5ff370b87668ef9001385507c1
Author: steve <steve@zanderz.com>
Date: Mon May 08 20:00:55 2017

Add Steve Sanders to AUTHORS for issue 2829693003

BUG= 712871 

Review-Url: https://codereview.chromium.org/2862733002
Cr-Commit-Position: refs/heads/master@{#470093}

[modify] https://crrev.com/ebd3740c435c3e5ff370b87668ef9001385507c1/AUTHORS
Project Member

Comment 2 by bugdroid1@chromium.org, May 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1aa2783638e90007c9e1b0a67beafc2080780faa

commit 1aa2783638e90007c9e1b0a67beafc2080780faa
Author: steve <steve@zanderz.com>
Date: Fri May 19 03:10:47 2017

Fix stale display work_area on windows

Display screen work_area was not being updated when the location of the taskbar
changed. The notification comes as WM_SETTINGCHANGE with SPI_SETWORKAREA, which
failed to trigger a reset of the stored values without this change.

BUG= 712871 

Review-Url: https://codereview.chromium.org/2829693003
Cr-Commit-Position: refs/heads/master@{#473055}

[modify] https://crrev.com/1aa2783638e90007c9e1b0a67beafc2080780faa/ui/display/win/screen_win.cc

Comment 3 by kebalaji@chromium.org, Oct 10 2017

Cc: st...@zanderz.com
Labels: Needs-Milestone
Owner: robliao@chromium.org
Status: Assigned (was: Unconfirmed)
@robliao: If there is no further update to be done on this issue, please close this issue since fix has been landed.

Thanks!

Comment 4 by robliao@chromium.org, Oct 10 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment