The csspaint/invalidation-* layout tests should not use console logs to assert test results |
|||||
Issue descriptionIn general, layout tests that use testharness.js where all subtests "PASS" are considered passing, and console logs are ignored when determining pass/fail. So, with the current status of things, the tests: csspaint/invalidation-background-image.html csspaint/invalidation-border-image.html csspaint/invalidation-content-image.html would be considered passing even if they had console messages indicating failure. Specifically, I think it would be good to change csspaint/resources/test-runner-invalidation-logging.js to use testharness asserts instead of logging "Successful invalidation for ...". See bug 687492 for more context.
,
Apr 19 2017
@qyearsley So this will actually require a bit of a refactor as there isn't any communication channel from inside a paint worklet to the main JS global.
,
Apr 19 2017
Darn. Well, this isn't urgent, although currently if all testharness subtests PASS, then the console message text will be ignored, so there's a danger that the test could start failing and we wouldn't know. As a temporary workaround to ensure that this doesn't happen, you could add an intentional fail in these tests so that the -expected.txt is used.
,
Apr 20 2017
,
Dec 6 2017
,
Dec 6
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 6
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by sashab@chromium.org
, Apr 19 2017