https://codereview.chromium.org/2823233003/

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/847504d1a2c7212f33fece91a85426f091d30f7f

commit 847504d1a2c7212f33fece91a85426f091d30f7f
Author: elawrence <elawrence@chromium.org>
Date: Wed Apr 19 21:20:28 2017

Deprecate Once-Per-Origin Navigation histograms

As a part of scoping changes to behavior, we want to collect the absolute number of page navigations in Incognito mode instead of counting only once-per-origin. This CL deprecates the old metrics.

BUG= 712843 
TEST=components_unittests --gtest_filter=NavigationMetrics*.*

Review-Url: https://codereview.chromium.org/2823233003
Cr-Commit-Position: refs/heads/master@{#465752}

[modify] https://crrev.com/847504d1a2c7212f33fece91a85426f091d30f7f/chrome/browser/BUILD.gn
[modify] https://crrev.com/847504d1a2c7212f33fece91a85426f091d30f7f/chrome/browser/tab_contents/navigation_metrics_recorder.cc
[delete] https://crrev.com/fed3fc6630e9ea6248153708b7f9a301b98624c4/chrome/browser/tab_contents/origins_seen_service_factory.cc
[delete] https://crrev.com/fed3fc6630e9ea6248153708b7f9a301b98624c4/chrome/browser/tab_contents/origins_seen_service_factory.h
[modify] https://crrev.com/847504d1a2c7212f33fece91a85426f091d30f7f/components/navigation_metrics/BUILD.gn
[modify] https://crrev.com/847504d1a2c7212f33fece91a85426f091d30f7f/components/navigation_metrics/navigation_metrics.cc
[modify] https://crrev.com/847504d1a2c7212f33fece91a85426f091d30f7f/components/navigation_metrics/navigation_metrics.h
[modify] https://crrev.com/847504d1a2c7212f33fece91a85426f091d30f7f/components/navigation_metrics/navigation_metrics_unittest.cc
[delete] https://crrev.com/fed3fc6630e9ea6248153708b7f9a301b98624c4/components/navigation_metrics/origins_seen_service.cc
[delete] https://crrev.com/fed3fc6630e9ea6248153708b7f9a301b98624c4/components/navigation_metrics/origins_seen_service.h
[modify] https://crrev.com/847504d1a2c7212f33fece91a85426f091d30f7f/ios/chrome/browser/metrics/BUILD.gn
[delete] https://crrev.com/fed3fc6630e9ea6248153708b7f9a301b98624c4/ios/chrome/browser/metrics/ios_chrome_origins_seen_service_factory.cc
[delete] https://crrev.com/fed3fc6630e9ea6248153708b7f9a301b98624c4/ios/chrome/browser/metrics/ios_chrome_origins_seen_service_factory.h
[modify] https://crrev.com/847504d1a2c7212f33fece91a85426f091d30f7f/ios/chrome/browser/tabs/tab.mm
[modify] https://crrev.com/847504d1a2c7212f33fece91a85426f091d30f7f/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16908bf6ea4341513c47b4c861a2408c55941a30

commit 16908bf6ea4341513c47b4c861a2408c55941a30
Author: elawrence <elawrence@chromium.org>
Date: Thu Apr 20 21:26:48 2017

Add Incognito Navigation histograms

As a part of scoping changes to behavior, we want to collect the
absolute number of page navigations in Incognito mode.

BUG= 712843 
TEST=components_unittests --gtest_filter=NavigationMetrics*.*

Review-Url: https://codereview.chromium.org/2827983003
Cr-Commit-Position: refs/heads/master@{#466140}

[modify] https://crrev.com/16908bf6ea4341513c47b4c861a2408c55941a30/components/navigation_metrics/navigation_metrics.cc
[modify] https://crrev.com/16908bf6ea4341513c47b4c861a2408c55941a30/components/navigation_metrics/navigation_metrics_unittest.cc
[modify] https://crrev.com/16908bf6ea4341513c47b4c861a2408c55941a30/tools/metrics/histograms/histograms.xml

Since we're trying to get a metrics baseline for changes we plan to make in an upcoming release, I'd like to take the CL in #3 to M59. Any objections to that?

Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22ae1aa67a701300ac2714312fc2d5319cf84247

commit 22ae1aa67a701300ac2714312fc2d5319cf84247
Author: Eric Lawrence <elawrence@chromium.org>
Date: Fri Apr 21 22:05:07 2017

Add Incognito Navigation histograms

As a part of scoping changes to behavior, we want to collect the
absolute number of page navigations in Incognito mode.

BUG= 712843 
TEST=components_unittests --gtest_filter=NavigationMetrics*.*

Review-Url: https://codereview.chromium.org/2827983003
Cr-Commit-Position: refs/heads/master@{#466140}
(cherry picked from commit 16908bf6ea4341513c47b4c861a2408c55941a30)

Review-Url: https://codereview.chromium.org/2830413002 .
Cr-Commit-Position: refs/branch-heads/3071@{#131}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/22ae1aa67a701300ac2714312fc2d5319cf84247/components/navigation_metrics/navigation_metrics.cc
[modify] https://crrev.com/22ae1aa67a701300ac2714312fc2d5319cf84247/components/navigation_metrics/navigation_metrics_unittest.cc
[modify] https://crrev.com/22ae1aa67a701300ac2714312fc2d5319cf84247/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77447721b2d2531e5ff2e2ea364ab044eb1e4ce4

commit 77447721b2d2531e5ff2e2ea364ab044eb1e4ce4
Author: elawrence <elawrence@chromium.org>
Date: Fri Apr 21 23:33:02 2017

Add Incognito Navigation histograms

As a part of scoping changes to behavior, we want to collect the
absolute number of page navigations in Incognito mode.

Modified tests for M59.

BUG= 712843 
TEST=components_unittests --gtest_filter=NavigationMetrics*.*
TBR=mpearson@google.com, davidben@chromium.org

NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2827983003
Cr-Commit-Position: refs/heads/master@{#466140}
(cherry picked from commit 16908bf6ea4341513c47b4c861a2408c55941a30)

Review-Url: https://codereview.chromium.org/2829013004
Cr-Commit-Position: refs/branch-heads/3071@{#137}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/77447721b2d2531e5ff2e2ea364ab044eb1e4ce4/components/navigation_metrics/navigation_metrics.cc
[modify] https://crrev.com/77447721b2d2531e5ff2e2ea364ab044eb1e4ce4/components/navigation_metrics/navigation_metrics_unittest.cc
[modify] https://crrev.com/77447721b2d2531e5ff2e2ea364ab044eb1e4ce4/tools/metrics/histograms/histograms.xml