New issue
Advanced search Search tips

Issue 712841 link

Starred by 0 users

Issue metadata

Status: Duplicate
Merged: issue 673873
Owner: ----
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

builder links should be to public buildbot URLs by default

Project Member Reported by ojan@chromium.org, Apr 18 2017

Issue description

When I file a bug and link to buildbot for revert, it's important that it be a publicly accessible URL so that if the author of the patch doesn't work at Google, they can actually see the failure without needing to get help from a Googler.

So, the builder links thing should link to buildbot by default. 

I understand that some bots only have an internal one, and so should link to the appropriate internal URL.

Why is there a radio button at all for this? Why isn't it just linking to buildbot unless it's an internal only bot, in which case it links to uberchromegw?
 
I like the idea of replacing the builder selection with defaulting to a public URL then an internal one if public is not available. We'd have to figure out what to do about linking to Milo though. 

Was there a reason why people wanted links to uberchromegw on builders that were public in some instances? I feel like I have a vague memory of something like this, but I'm not sure. 

If we can come up with a good default behavior that people like, I think it's better for users to not have to think about too many settings. 
Labels: Milestone-Workflow
Status: Available (was: Untriaged)
uberchromegw offers extra features like canceling/retrying builds, comments on steps etc. The radio button is to support sheriffs who want to use these features.

It is probably better to link to public by default but uberchromegw for now, if we know it's an internal builder. Eventually Milo should probably implement the extra uberchromegw features and we can delegate the ACLing to it once we link to it for all builds.

Mergedinto: 673873
Status: Duplicate (was: Available)

Sign in to add a comment