Occasional crash when attempting to unregister VR Entry BroadcastReceiver |
||||||
Issue descriptionI'm not sure why we crash - we're using a weakReference to an activity we definitely register a receiver on, yet unregisterReceiver still occasionally crashes.
,
Apr 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3eb6c9fae5bf061ac97480aa6670858c7c8cbc8f commit 3eb6c9fae5bf061ac97480aa6670858c7c8cbc8f Author: mthiesse <mthiesse@chromium.org> Date: Wed Apr 19 19:24:09 2017 Prevent possible crash unregistering VR BroadcastReceiver I only saw this crash once, and can't reproduce, but better safe than sorry. BUG= 712823 Review-Url: https://codereview.chromium.org/2830463002 Cr-Commit-Position: refs/heads/master@{#465702} [modify] https://crrev.com/3eb6c9fae5bf061ac97480aa6670858c7c8cbc8f/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
,
Apr 19 2017
,
Apr 19 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/31f6c164d4138dd81258d5afdefef59fd2abdefd commit 31f6c164d4138dd81258d5afdefef59fd2abdefd Author: Michael Thiessen <mthiesse@chromium.org> Date: Wed Apr 19 19:33:28 2017 Prevent possible crash unregistering VR BroadcastReceiver I only saw this crash once, and can't reproduce, but better safe than sorry. BUG= 712823 Review-Url: https://codereview.chromium.org/2830463002 Cr-Commit-Position: refs/heads/master@{#465702} (cherry picked from commit 3eb6c9fae5bf061ac97480aa6670858c7c8cbc8f) Review-Url: https://codereview.chromium.org/2826213002 . Cr-Commit-Position: refs/branch-heads/3071@{#62} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/31f6c164d4138dd81258d5afdefef59fd2abdefd/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
,
Apr 19 2017
,
Jul 4
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by mthiesse@chromium.org
, Apr 19 2017