New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 712815 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----

Blocking:
issue 714267



Sign in to add a comment

findit spends too many pixels telling me it can't help me

Project Member Reported by ojan@chromium.org, Apr 18 2017

Issue description

The FindIt integration with the icon and the orange text makes sense for when it is helping me solve my problem. But the "Not supported by Findit." and the "Findit found no culprit." messages are less useful to me. It's useful to know, but it should be less obtrusive.

Incidentally, so far, half a day into sheriffing, I have yet to see a case where FindIt actually found a culprit. So the visual clutter is even more frustrating.
 
Cc: chanli@chromium.org
Labels: Milestone-UX
Status: Available (was: Untriaged)

Comment 2 by chanli@chromium.org, Apr 19 2017

Cc: -chanli@chromium.org
Owner: chanli@chromium.org
Status: Assigned (was: Available)

Comment 3 by chanli@chromium.org, Apr 19 2017

Blocking: 711831
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/078ab103c46e9f396960187d36e9fb74f653bb98

commit 078ab103c46e9f396960187d36e9fb74f653bb98
Author: Chan <chanli@chromium.org>
Date: Wed Apr 19 23:35:15 2017

[Som-Findit] Display a less obtrusive message when Findit doesn't have results for an alert.

Bug:  712815 
Change-Id: I313237eab595a1a9ed1558d706a01f272d6feac2
Reviewed-on: https://chromium-review.googlesource.com/481881
Reviewed-by: Sean McCullough <seanmccullough@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>

[modify] https://crrev.com/078ab103c46e9f396960187d36e9fb74f653bb98/go/src/infra/appengine/sheriff-o-matic/elements/som-extension-build-failure/som-extension-build-failure.html

Comment 5 by ojan@chromium.org, Apr 20 2017

Incidentally, do you track what percentage of alerts in sheriff-o-matic findit finds an answer for? That seems like a good number to track and have OKRs to improve.

Comment 6 by chanli@chromium.org, Apr 20 2017

We don't have such metrics but I agree that this is a good number to track and improve. I'll make a change to start to collect this data.

Comment 7 by chanli@chromium.org, Apr 20 2017

Cc: st...@chromium.org

Comment 8 by chanli@chromium.org, Apr 24 2017

Blocking: -711831 714248

Comment 9 by chanli@chromium.org, Apr 24 2017

Blocking: 714267
Blocking: -714248
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/687c32fdd368160520c3573de224bd4f80d68373

commit 687c32fdd368160520c3573de224bd4f80d68373
Author: Chan <chanli@chromium.org>
Date: Fri Apr 28 18:04:23 2017

[Findit] Script to calculate detection rate for Findit analyses.

1. The metrics for compile failure and test failure is separated
2. This script checks Findit analyses with suspects/culprits, found flakiness, not supported, errored out, without any result
3. To deduplicate, only first failures are considered. But it still can't match alerts in SoM
4. Same step/ test failures are not grouped since we don't always have enough information to do the grouping

Bug:  712815 
Change-Id: I66a13080073d638015801c45f2ef11d94fef049a
Reviewed-on: https://chromium-review.googlesource.com/486951
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[add] https://crrev.com/687c32fdd368160520c3573de224bd4f80d68373/appengine/findit/util_scripts/remote_queries/detection_rate_at_step_level.py

Blocking: 717089
Blocking: -717089
Labels: Milestone-Polish
Status: Fixed (was: Assigned)
Tidying up some old sheriffing bugs. I think this was fixed a while ago, so I'm marking it as Fixed. 

Sign in to add a comment