hide alerts with bugs needs work |
|||||
Issue descriptionGiven issue 712808 , hide alerts with bugs is almost always incorrectly hiding issues because the issues have incorrect bugs. In addition, this doesn't seem like what we want to encourage with sheriffing. I think you want issues where you've filed a bug and don't want to do more work on it to be out of your way for a while, but there are ways to do that that don't hide that there are still potentially alerts firing you might need to check in on. For example, you could autosnooze + collapse issues for 2 hours when you add a bug to them. That way, you also don't need a checkbox. You can just make it the default behavior.
,
Apr 19 2017
,
Apr 19 2017
Marking P1 since this is harmful until either this or issue 712808 is fixed. I've been thinking more about the user experience I want. I think the autosnooze is really the right way to handle this, but you might need a different duration of autosnooze per tree. The chromium tree probably wants something in the 1-2hr range, whereas the perf one might want 1-2 days?
,
Apr 19 2017
I'll work on this now then. Autosnooze makes sense to me (and combining this with collapsing snoozed items by default). Perhaps when a user links a bug there could be a checkbox to autosnooze the alert that is checked by default but can be unchecked if a user wants. Having different default snooze times per tree is a useful idea in general, I think. We could also use the different per tree defaults in the normal snooze function.
,
Apr 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/26f530fdb25950e4b23acbc3415571ed24e3ed74 commit 26f530fdb25950e4b23acbc3415571ed24e3ed74 Author: Tiff Zhang <zhangtiff@google.com> Date: Wed Apr 19 21:13:06 2017 Replace hiding alerts with bug with autosnoozing on link bug. Bug:712810 Change-Id: I4b456fa1602cc2146c34a9bef5d77e66a90863db Reviewed-on: https://chromium-review.googlesource.com/482419 Commit-Queue: Tiffany Zhang <zhangtiff@chromium.org> Reviewed-by: Sean McCullough <seanmccullough@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org> [modify] https://crrev.com/26f530fdb25950e4b23acbc3415571ed24e3ed74/go/src/infra/appengine/sheriff-o-matic/test/som-annotations-test.html [modify] https://crrev.com/26f530fdb25950e4b23acbc3415571ed24e3ed74/go/src/infra/appengine/sheriff-o-matic/elements/som-drawer/som-drawer.js [modify] https://crrev.com/26f530fdb25950e4b23acbc3415571ed24e3ed74/go/src/infra/appengine/sheriff-o-matic/elements/som-drawer/som-drawer.html [modify] https://crrev.com/26f530fdb25950e4b23acbc3415571ed24e3ed74/go/src/infra/appengine/sheriff-o-matic/elements/som-app/som-app.html [modify] https://crrev.com/26f530fdb25950e4b23acbc3415571ed24e3ed74/go/src/infra/appengine/sheriff-o-matic/elements/som-annotations/som-annotations.html [modify] https://crrev.com/26f530fdb25950e4b23acbc3415571ed24e3ed74/go/src/infra/appengine/sheriff-o-matic/elements/som-app/som-app.js [modify] https://crrev.com/26f530fdb25950e4b23acbc3415571ed24e3ed74/go/src/infra/appengine/sheriff-o-matic/test/som-app-test.html [modify] https://crrev.com/26f530fdb25950e4b23acbc3415571ed24e3ed74/go/src/infra/appengine/sheriff-o-matic/elements/som-annotations/som-annotations.js
,
Apr 25 2017
Autosnoozing should be out with the next release. Thanks! :) |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by zhangtiff@chromium.org
, Apr 18 2017