New issue
Advanced search Search tips

Issue 712794 link

Starred by 1 user
Status: Fixed
Owner:
kenrb@chromium.org
Closed: Apr 2017
Cc:
ericrk@chromium.org
wfh@chromium.org
creis@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Set GPU rasterization trigger for OOPIFs

Project Member Reported by kenrb@chromium.org, Apr 18 2017 

For OOPIF compositors, LayerTreeHost::SetHasGpuRasterizationTrigger is currently never called, since its only caller is currently WebViewImpl, whose compositor doesn't do anything in OOPIF processes.

GPU rasterization shouldn't trigger on Android when there is a meta viewport, which doesn't apply to iframes. Correspondingly it seems to make sense to call SetHasGpuRasterizationTrigger(true) for OOPIFs in all cases.

Comment 1 by kenrb@chromium.org, Apr 26 2017 

Landed a temporary fix at https://codereview.chromium.org/2828023002/.

As noted on that CL, permanently enabling GPU rasterization for OOPIFs is undesirable, and it would be better if it behaved the same as the top-level frame. I will leave this bug open for that to be fixed.

Comment 2 by kenrb@chromium.org, Apr 27 2017 

ericrk@: Is this something that should be merged to M59? We have a lot more OOPIFs coming into use on stable now, and I don't know how big a problem it is that they aren't using GPU rasterization.

Comment 3 by kenrb@chromium.org, Apr 28 2017

Labels: Merge-Request-59 M-59 OS-All
Status: Fixed (was: Assigned)
Closing and requesting merge. Follow-up work has been moved to bug 716550.
Project Member

Comment 4 by sheriffbot@chromium.org, Apr 29 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, May 1 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c3f45c74fa610abd2d45b6fd9305496bcd40d67

commit 6c3f45c74fa610abd2d45b6fd9305496bcd40d67
Author: Ken Buchanan <kenrb@chromium.org>
Date: Mon May 01 17:18:05 2017

Set GPU rasterization trigger for OOPIFs

Currently the GPU rasterization trigger is never set on the compositor
for an out-of-process iframe. This patch changes it so that it is always
set.

BUG= 712794 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2828023002
Cr-Commit-Position: refs/heads/master@{#467130}
(cherry picked from commit 1931faea0d5ada216fca3c11add153ceaa82ba6d)

Review-Url: https://codereview.chromium.org/2849173002 .
Cr-Commit-Position: refs/branch-heads/3071@{#326}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/6c3f45c74fa610abd2d45b6fd9305496bcd40d67/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
►

Sign in to add a comment