New issue
Advanced search Search tips

Issue 712763 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug


Participants' hotlists:
IDB-Scaling


Sign in to add a comment

Investigate IndexedDB spec changes for allowing more efficient memory usage

Project Member Reported by dmu...@chromium.org, Apr 18 2017

Issue description

Investigation from https://docs.google.com/document/d/1PphqDNEMLueeTtK5OZDN4HtnQ_hrRHEEQXmyr-C8ST0/edit

Ideas:
* Allow the developer to close a cursor.
*
 

Comment 1 by dmu...@chromium.org, Apr 18 2017

Cc: pwnall@chromium.org jsb...@chromium.org dmu...@chromium.org

Comment 2 by dmu...@chromium.org, Apr 18 2017

Labels: -Pri-1 Pri-2

Comment 3 by jsb...@chromium.org, Apr 18 2017

FYI, you should be able to mimic closing a cursor with `continue(MAX_KEY)` where MAX_KEY is some key beyond the range or beyond your top key or something like [[[[]]]] (there is no actual maximum key defined in the spec)

I mention this (1) as a bread crumb for anyone who stumbles on this bug and (2) because we should actually verify that this frees resources. :)

Comment 4 by jsb...@chromium.org, Apr 18 2017

FR on the spec for cursor.close(): https://github.com/w3c/IndexedDB/issues/185

Comment 5 by jsb...@chromium.org, Apr 18 2017

From code inspection on cursors hitting the end of range...

https://cs.chromium.org/chromium/src/content/browser/indexed_db/indexed_db_cursor.cc?dr&l=150

It looks like we don't free all possible data (cursor_ is reset, but not everything done in https://cs.chromium.org/chromium/src/content/browser/indexed_db/indexed_db_cursor.cc?dr&l=275)

Comment 6 by dmu...@chromium.org, Apr 19 2017

Owner: jsb...@chromium.org
Labels: Postmortem-Followup
Owner: ----
Labels: -Pri-2 Pri-3

Sign in to add a comment