New issue
Advanced search Search tips

Issue 712729 link

Starred by 1 user
Status: Verified
Owner:
khmel@chromium.org
Closed: May 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

arc: Chrome badging does not always applied on ARC state change.

Project Member Reported by khmel@chromium.org, Apr 18 2017 
1. Make sure that some Chrome conflicting apps is available for ARC OptIn
2. OptIn ARC.
3. Chrome conflicting apps should change icon to badged but do not. If icon was loaded it never changes its view until resigned in.

The same problem for Opt-out (badged icon stays badged in case Opt-out or corresponded ARC app is uninstalled).

This is regression at least in M57/M58

Comment 1 by khmel@chromium.org, Apr 18 2017 

Inner bug: b/37418449

Comment 2 by uekawa@google.com, May 10 2017

Labels: -M-58 M-60
Project Member

Comment 3 by bugdroid1@chromium.org, May 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c1f6622f0279ee6062496672a7b83317b579486

commit 8c1f6622f0279ee6062496672a7b83317b579486
Author: khmel <khmel@chromium.org>
Date: Thu May 11 19:15:07 2017

Refactor extension app icon.

We have several independent places where we decided how extension icon
is represented. We have separate logic for the shelf, recent view, app
list and app info icons. Icon look depends on type of app and some
external conditions. This leads to situation that extension App icon
looks differently in different places. Yet another problem is non-stable
applying Chrome badging in case corresponded ARC app is installed or
uninstalled.

Solution is to provide centrilized place where app icon is processed
and all consumers should use. ChromeAppIcon is introduced that applies all necessary effects based on current environment and app type. ChromeAppIconService is introduced to refer all created icons,
monitor environment changes and updating the icon. Resulting icon
image is sent to consumer via ChromeAppIconDelegate interface.

BUG= 712729 
BUG= 703366 
BUG=b/37418449
Test=Manually on device. Existing tests passed.

TBR=yoshiki@chromium.org

Review-Url: https://codereview.chromium.org/2819413003
Cr-Commit-Position: refs/heads/master@{#471035}

[modify] https://crrev.com/8c1f6622f0279ee6062496672a7b83317b579486/chrome/browser/chromeos/extensions/gfx_utils.cc
[modify] https://crrev.com/8c1f6622f0279ee6062496672a7b83317b579486/chrome/browser/chromeos/file_system_provider/notification_manager.cc
[modify] https://crrev.com/8c1f6622f0279ee6062496672a7b83317b579486/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/8c1f6622f0279ee6062496672a7b83317b579486/chrome/browser/extensions/api/file_system/request_file_system_notification.cc
[add] https://crrev.com/8c1f6622f0279ee6062496672a7b83317b579486/chrome/browser/extensions/chrome_app_icon.cc
[add] https://crrev.com/8c1f6622f0279ee6062496672a7b83317b579486/chrome/browser/extensions/chrome_app_icon.h
[add] https://crrev.com/8c1f6622f0279ee6062496672a7b83317b579486/chrome/browser/extensions/chrome_app_icon_delegate.h
[add] https://crrev.com/8c1f6622f0279ee6062496672a7b83317b579486/chrome/browser/extensions/chrome_app_icon_loader.cc
[add] https://crrev.com/8c1f6622f0279ee6062496672a7b83317b579486/chrome/browser/extensions/chrome_app_icon_loader.h
[add] https://crrev.com/8c1f6622f0279ee6062496672a7b83317b579486/chrome/browser/extensions/chrome_app_icon_service.cc
[add] https://crrev.com/8c1f6622f0279ee6062496672a7b83317b579486/chrome/browser/extensions/chrome_app_icon_service.h
[add] https://crrev.com/8c1f6622f0279ee6062496672a7b83317b579486/chrome/browser/extensions/chrome_app_icon_service_factory.cc
[add] https://crrev.com/8c1f6622f0279ee6062496672a7b83317b579486/chrome/browser/extensions/chrome_app_icon_service_factory.h
[add] https://crrev.com/8c1f6622f0279ee6062496672a7b83317b579486/chrome/browser/extensions/chrome_app_icon_unittest.cc
[delete] https://crrev.com/d348b44325689e6d2ecf5ba9896ed26ec68ee97d/chrome/browser/extensions/extension_app_icon_loader.cc
[delete] https://crrev.com/d348b44325689e6d2ecf5ba9896ed26ec68ee97d/chrome/browser/extensions/extension_app_icon_loader.h
[modify] https://crrev.com/8c1f6622f0279ee6062496672a7b83317b579486/chrome/browser/notifications/application_notifier_source.cc
[modify] https://crrev.com/8c1f6622f0279ee6062496672a7b83317b579486/chrome/browser/notifications/application_notifier_source.h
[modify] https://crrev.com/8c1f6622f0279ee6062496672a7b83317b579486/chrome/browser/ui/app_icon_loader.h
[modify] https://crrev.com/8c1f6622f0279ee6062496672a7b83317b579486/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
[modify] https://crrev.com/8c1f6622f0279ee6062496672a7b83317b579486/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h
[modify] https://crrev.com/8c1f6622f0279ee6062496672a7b83317b579486/chrome/browser/ui/app_list/arc/arc_package_syncable_service.cc
[modify] https://crrev.com/8c1f6622f0279ee6062496672a7b83317b579486/chrome/browser/ui/app_list/arc/arc_package_syncable_service.h
[modify] https://crrev.com/8c1f6622f0279ee6062496672a7b83317b579486/chrome/browser/ui/app_list/extension_app_item.cc
[modify] https://crrev.com/8c1f6622f0279ee6062496672a7b83317b579486/chrome/browser/ui/app_list/extension_app_item.h
[modify] https://crrev.com/8c1f6622f0279ee6062496672a7b83317b579486/chrome/browser/ui/app_list/extension_app_model_builder.cc
[modify] https://crrev.com/8c1f6622f0279ee6062496672a7b83317b579486/chrome/browser/ui/app_list/extension_app_model_builder.h
[modify] https://crrev.com/8c1f6622f0279ee6062496672a7b83317b579486/chrome/browser/ui/app_list/search/extension_app_result.cc
[modify] https://crrev.com/8c1f6622f0279ee6062496672a7b83317b579486/chrome/browser/ui/app_list/search/extension_app_result.h
[modify] https://crrev.com/8c1f6622f0279ee6062496672a7b83317b579486/chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.cc
[modify] https://crrev.com/8c1f6622f0279ee6062496672a7b83317b579486/chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.h
[modify] https://crrev.com/8c1f6622f0279ee6062496672a7b83317b579486/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc
[modify] https://crrev.com/8c1f6622f0279ee6062496672a7b83317b579486/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h
[modify] https://crrev.com/8c1f6622f0279ee6062496672a7b83317b579486/chrome/browser/ui/ash/launcher/launcher_extension_app_updater.cc
[modify] https://crrev.com/8c1f6622f0279ee6062496672a7b83317b579486/chrome/browser/ui/ash/launcher/launcher_extension_app_updater.h
[modify] https://crrev.com/8c1f6622f0279ee6062496672a7b83317b579486/chrome/browser/ui/views/apps/app_info_dialog/app_info_header_panel.cc
[modify] https://crrev.com/8c1f6622f0279ee6062496672a7b83317b579486/chrome/browser/ui/views/apps/app_info_dialog/app_info_header_panel.h
[modify] https://crrev.com/8c1f6622f0279ee6062496672a7b83317b579486/chrome/test/BUILD.gn
[add] https://crrev.com/8c1f6622f0279ee6062496672a7b83317b579486/chrome/test/data/extensions/app_list/Extensions/emfkafnhnpcmabnnkckkchdilgeoekbo/1.0/icon_128.png
[modify] https://crrev.com/8c1f6622f0279ee6062496672a7b83317b579486/chrome/test/data/extensions/app_list/Extensions/emfkafnhnpcmabnnkckkchdilgeoekbo/1.0/manifest.json
[modify] https://crrev.com/8c1f6622f0279ee6062496672a7b83317b579486/chrome/test/data/extensions/app_list/Preferences

Comment 4 by khmel@chromium.org, May 11 2017

Status: Fixed (was: Started)

Comment 5 by sdantul...@chromium.org, May 16 2017

Status: Verified (was: Fixed)
9557.0.0, 60.0.3101.0
►

Sign in to add a comment