Add ash_mus_unittests, mash_unittests and mus_ws_unittests to memory bots |
||||||
Issue descriptionWe need to ensure there aren't any issues with these tests on the memory bots.
,
Apr 19 2017
I suspect we'll have things that need to be fixed, so we shouldn't just add to the main waterfall. I hope there are some fyi memory bots we could add this to, but maybe not. Oshima + Lei, any ideas? We're wondering if there is an fyi bot that builds chromeos ozone for asan/msan that we can add some tests to until they are ready for the main waterfall.
,
Apr 19 2017
memory.fyi became memory.full, but then we dropped most of the non-santizier bots. The remaining bots got merged into the memory waterfall, so there is no memory.fyi waterfall left. I looked on https://build.chromium.org/p/chromium.fyi/waterfall and didn't see any appropriate bots. I recommend either setting up bots with the configs you want on chromium.fyi, or take the unit tests one at a time, make sure it passes locally with ASAN/MSAN, and then stick it on the existing memory bots.
,
Apr 19 2017
Yes, no more memory.fyi. Alternative way is to create a memory bots only filter (not sure if it's possible now, but should be doable), add to main waterfall, then enable as we fix memory issues.
,
Apr 19 2017
It took me 10 minutes to 1) create a new out/ dir for cros + ozone + asan, 2) build, 3) run tests. No ASAN errors here. I didn't see an ash_mus_unittests target, so I tried ash_unittests (which stole my mouse cursor!) instead. Maybe the code is good shape and you can just add the new tests to the memory bots, without worrying too much about them failing.
,
Apr 19 2017
With MSAN, mus_ws_unittests is complaining about uninit data inside gl::GLSurfaceEGL::GetConfig() in a bunch of tests. Also, I figured out what "ash_mus_unittests" really is.
,
Apr 19 2017
Thanks for trying Lei (and figuring out how to run ash_mus_unittests). We'll investigate GetConfig. I wonder if that happens when you run without --mus.
,
May 8 2017
Issue 568834 has been merged into this issue.
,
Jun 8 2017
,
Jul 25 2017
Kyle, is this something you could take a look at?
,
Jul 26 2017
I can take a look, I'm getting a few other disabled tests running on the CrOS Asan/LSan bot now too.
,
Aug 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e5f21ea732cf6b7071a9bbb1577fc9d2e6697e51 commit e5f21ea732cf6b7071a9bbb1577fc9d2e6697e51 Author: kylechar <kylechar@chromium.org> Date: Thu Aug 24 23:29:51 2017 Add mus tests to CrOS ASan trybot. Both tests pass locally running with ASan on. Bug: 712727 Change-Id: Ia5cb2404de9a01a7003c447ae60de546064b9c11 Reviewed-on: https://chromium-review.googlesource.com/633489 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#497247} [modify] https://crrev.com/e5f21ea732cf6b7071a9bbb1577fc9d2e6697e51/testing/buildbot/chromium.memory.json
,
Aug 25 2017
,
Jan 22 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by jonr...@chromium.org
, Apr 19 2017