New issue
Advanced search Search tips

Issue 712719 link

Starred by 1 user
Status: Verified
Owner:
mcasas@chromium.org
Closed: Apr 2017
Cc:
fbeaufort@chromium.org
mcasas@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Image Capture: don't show |torch| in capabilities if not supported

Project Member Reported by mcasas@chromium.org, Apr 18 2017 
If torch (meaning: flash continuously on) is not supported,
currently MediaStreamTrack.getCapabilities().torch says false;
instead it should just not show it up (since the result is a
dictionary of supported capabilities).
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31b31da235decd6c593745e98f77b55ff9270cb4

commit 31b31da235decd6c593745e98f77b55ff9270cb4
Author: mcasas <mcasas@chromium.org>
Date: Tue Apr 18 21:09:50 2017

ImageCapture: don't list |torch| in Capabilities if not supported

Currently MediaStreamTrack.getCapabilities() returns
 torch : false

when |torch| is not supported; this CL aligns with the
other dictionary members behaviour, which is to not
show up in the Capabilities dictionary when not supported.

BUG= 712719 

Review-Url: https://codereview.chromium.org/2827693003
Cr-Commit-Position: refs/heads/master@{#465373}

[modify] https://crrev.com/31b31da235decd6c593745e98f77b55ff9270cb4/third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp

Comment 2 by mcasas@chromium.org, Apr 19 2017

Labels: Merge-Request-59 M-59

Comment 3 by fbeaufort@google.com, Apr 19 2017 

Verified in Chromium 60.0.3074.0.
Thank you Miguel!

Comment 4 by mcasas@chromium.org, Apr 19 2017

Labels: -Merge-Request-59

Comment 5 by mcasas@chromium.org, Apr 19 2017

Labels: Merge-Request-59
Project Member

Comment 6 by sheriffbot@chromium.org, Apr 19 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 19 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89bfdc09da805adc9bb85bfcb4e38e62bb3d2833

commit 89bfdc09da805adc9bb85bfcb4e38e62bb3d2833
Author: Miguel Casas-Sanchez <mcasas@chromium.org>
Date: Wed Apr 19 22:32:59 2017

ImageCapture: don't list |torch| in Capabilities if not supported

Currently MediaStreamTrack.getCapabilities() returns
 torch : false

when |torch| is not supported; this CL aligns with the
other dictionary members behaviour, which is to not
show up in the Capabilities dictionary when not supported.

BUG= 712719 

Review-Url: https://codereview.chromium.org/2827693003
Cr-Commit-Position: refs/heads/master@{#465373}
(cherry picked from commit 31b31da235decd6c593745e98f77b55ff9270cb4)

Review-Url: https://codereview.chromium.org/2830943002 .
Cr-Commit-Position: refs/branch-heads/3071@{#69}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/89bfdc09da805adc9bb85bfcb4e38e62bb3d2833/third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp

Comment 8 by mcasas@chromium.org, Apr 19 2017

Status: Verified (was: Assigned)
verified per #3
►

Sign in to add a comment