New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 712715 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

inkdrop check failures when system is busy

Project Member Reported by est...@chromium.org, Apr 18 2017

Issue description

when the system is bogged down I often see crashes like this:

#0 0x7fa03413f067 base::debug::StackTrace::StackTrace()
#1 0x7fa03413ebdf base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7fa0342b9330 <unknown>
#3 0x7fa029f39c37 gsignal
#4 0x7fa029f3d028 abort
#5 0x7fa03413d1a2 base::debug::BreakDebugger()
#6 0x7fa0341622d5 logging::LogMessage::~LogMessage()
#7 0x7fa02f9e9ff1 views::FloodFillInkDropRipple::AnimateStateChange()
#8 0x7fa02f9efc7b views::InkDropRipple::AnimateToState()
#9 0x7fa02f9ecc94 views::InkDropHostView::AnimateInkDrop()
#10 0x7fa02f9fdf75 views::CustomButton::OnMousePressed()
#11 0x7fa02f20afff ash::AppListButton::OnMousePressed()
#12 0x7fa02fa61712 views::View::ProcessMousePressed()
#13 0x7fa02fa61485 views::View::OnMouseEvent()
#14 0x7fa02f9ecef1 views::InkDropHostView::OnMouseEvent()
#15 0x7fa030508c3d ui::EventDispatcher::ProcessEvent()
#16 0x7fa0305089ea ui::EventDispatcherDelegate::DispatchEvent()
#17 0x7fa02fa67e0e views::internal::RootView::OnMousePressed()
#18 0x7fa02fa6d78f views::Widget::OnMouseEvent()
#19 0x7fa02fa87d1f views::NativeWidgetAura::OnMouseEvent()
#20 0x7fa030508c3d ui::EventDispatcher::ProcessEvent()
#21 0x7fa0305089ea ui::EventDispatcherDelegate::DispatchEvent()
#22 0x7fa030509779 ui::EventProcessor::OnEventFromSource()
#23 0x7fa030509d76 ui::EventSource::SendEventToSink()
#24 0x7fa03034beb9 aura::WindowTreeHostX11::DispatchXI2Event()
#25 0x7fa03034b8a0 aura::WindowTreeHostX11::DispatchEvent()
#26 0x7fa0345035b6 ui::PlatformEventSource::DispatchEvent()
#27 0x7fa02eeda8ac ui::X11EventSource::ExtractCookieDataDispatchEvent()
#28 0x7fa02eeda85d ui::X11EventSource::DispatchXEvents()
#29 0x7fa02eeddf49 ui::(anonymous namespace)::XSourceDispatch()
#30 0x7fa02cb81ce5 g_main_context_dispatch
#31 0x7fa02cb82048 <unknown>
#32 0x7fa02cb820ec g_main_context_iteration
#33 0x7fa034170446 base::MessagePumpGlib::Run()
#34 0x7fa03416dd9a base::MessageLoop::RunHandler()
#35 0x7fa03419ec6f base::RunLoop::Run()
#36 0x7fa035772663 ChromeBrowserMainParts::MainMessageLoopRun()

example repro: run this javascript in a tab[1] and then click the app button twice.

[1]
while(1) console.log("slow");
 
Status: Started (was: Assigned)
https://chromium-review.googlesource.com/c/610364
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b380725a81987b7ff8725ad40a02306ebdd358c9

commit b380725a81987b7ff8725ad40a02306ebdd358c9
Author: Ben Ruthig <bruthig@chromium.org>
Date: Thu Aug 10 20:43:28 2017

Downgraded ink drop DCHECKs to DLOGs.

The DCHECKs were failing due to race conditions during a heavily loaded system
which is outside the scope of what they are supposed to be detecting, namely
incorrect input event streams.

Bug:  712715 ,  737449 
Change-Id: I5d540233f520cea304810b7bc64b7e3cd8dc71e7
Reviewed-on: https://chromium-review.googlesource.com/610364
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Ben Ruthig <bruthig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493530}
[modify] https://crrev.com/b380725a81987b7ff8725ad40a02306ebdd358c9/ui/views/animation/flood_fill_ink_drop_ripple.cc
[modify] https://crrev.com/b380725a81987b7ff8725ad40a02306ebdd358c9/ui/views/animation/ink_drop_ripple.cc
[modify] https://crrev.com/b380725a81987b7ff8725ad40a02306ebdd358c9/ui/views/animation/square_ink_drop_ripple.cc

Status: Fixed (was: Started)

Sign in to add a comment