desktopui_SonicExtension depends on chrome://settings-frame |
|||||
Issue descriptionchrome://setttings-frame is going away in M-60. We should not be relying on Chrome UI for autotest. Please convert desktopui_SonicExtension to use the chrome.autotestPrivate API or another chrome API instead. (Otherwise we will need to disable the test) See https://chromium-review.googlesource.com/#/c/470707/ for an example ( issue 694081 ).
,
May 23 2017
Reminder: This test will break and thus be disabled if it is not fixed for M-60. The problematic code is here: https://cs.corp.google.com/chromeos_public/src/third_party/autotest/files/client/site_tests/desktopui_SonicExtension/test_utils.py?q=chrome://settings+package:%5Echromeos_public$&l=112
,
May 23 2017
I am in the progress of fixing it (and possibly switching to another way to run the test). That should be done before M-60.
,
May 23 2017
,
Jun 2 2017
Is chrome://settings-frame going away? I am still seeing in M61 and the test is not breaking. Or is it just the test shouldn't rely on it?
,
Jun 2 2017
Both, but yes, sometime during the 61 cycle it will be removed from Chrome on all platforms. Maybe soon. The correct change depends on what exactly the test requires. If it just needs to set cros.metrics.reportingEnabled, the test should be able to do that using settingsPrivate.setPref: https://cs.chromium.org/chromium/src/chrome/common/extensions/api/settings_private.idl?q=settings_private.idl+package:%5Echromium$&l=67
,
Jul 24 2017
What is the status of this? chrome://settings-frame is being actively deprecated now. It is only semi-functional in 61.
,
Jul 24 2017
,
Jul 24 2017
Sorry that I forget to update this. The test has been migrated and these code are no longer needed. I am going to prepare a CL to delete these from repo.
,
Aug 3 2017
Any update on this?
,
Aug 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/1f0876589bc77cc701960531f9f6d80c7664da6d commit 1f0876589bc77cc701960531f9f6d80c7664da6d Author: Clifford Cheng <cliffordcheng@chromium.org> Date: Tue Aug 15 03:37:52 2017 Remove the media router performance test as it is moved to somewhere else. BUG= 712712 TEST=None Change-Id: Id246a9902f9567e8949e5a8ae2259722e80c71e9 Reviewed-on: https://chromium-review.googlesource.com/614588 Commit-Ready: Clifford Cheng <cliffordcheng@chromium.org> Tested-by: Clifford Cheng <cliffordcheng@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> [delete] https://crrev.com/18e5dc16be238089173c9bfb2dd65319d78e5d7f/client/site_tests/desktopui_SonicExtension/extension_pages/e2e_test_utils.py [delete] https://crrev.com/18e5dc16be238089173c9bfb2dd65319d78e5d7f/client/site_tests/desktopui_SonicExtension/config_json_iterator.py [delete] https://crrev.com/18e5dc16be238089173c9bfb2dd65319d78e5d7f/client/site_tests/desktopui_SonicExtension/hello.html [delete] https://crrev.com/18e5dc16be238089173c9bfb2dd65319d78e5d7f/client/site_tests/desktopui_SonicExtension/test_utils.py [delete] https://crrev.com/18e5dc16be238089173c9bfb2dd65319d78e5d7f/client/site_tests/desktopui_SonicExtension/extension_pages/options.py [delete] https://crrev.com/18e5dc16be238089173c9bfb2dd65319d78e5d7f/client/site_tests/desktopui_SonicExtension/config_manager.py [delete] https://crrev.com/18e5dc16be238089173c9bfb2dd65319d78e5d7f/client/site_tests/desktopui_SonicExtension/extension_pages/__init__.py [delete] https://crrev.com/18e5dc16be238089173c9bfb2dd65319d78e5d7f/client/site_tests/desktopui_SonicExtension/desktopui_SonicExtension.py [delete] https://crrev.com/18e5dc16be238089173c9bfb2dd65319d78e5d7f/client/site_tests/desktopui_SonicExtension/extension_pages/web_elements.py [delete] https://crrev.com/18e5dc16be238089173c9bfb2dd65319d78e5d7f/client/site_tests/desktopui_SonicExtension/extension_pages/extension_pages.py
,
Aug 15 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by dschuyler@chromium.org
, Apr 18 2017