New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 712705 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 712781



Sign in to add a comment

display_facade_native.py depends on chrome://settings-frame

Project Member Reported by steve...@chromium.org, Apr 18 2017

Issue description

chrome://setttings-frame is going away in M-60.

We should not be relying on Chrome UI for autotest.

Please convert display_facade_native.py to use the chrome.system.display API or the chrome.autotestPrivate API instead.

See https://chromium-review.googlesource.com/#/c/470707/ for an example ( issue 694081 ).

 
Cc: khmel@chromium.org
Components: -Tests>Telemetry Tests
Blocking: 712781
Cc: achuith@chromium.org
Owner: lhchavez@chromium.org
Status: Untriaged (was: Assigned)
Someone from ARC should take this on. Assigning to Luis for further triage.
Owner: victorhsieh@chromium.org
Assigning to this week's constable.
Cc: ka...@chromium.org rjahagir@chromium.org
CC'ed kalin@ and rjahagir@ for awareness

Comment 7 by wutao@chromium.org, Apr 20 2017

Cc: wutao@chromium.org
Status: Started (was: Untriaged)
Gardener this week.  My plan is to add general APIs for get/set settings.
Please add me as a reviewer for CLs - thank you!
Will do.  Update: I misunderstood the scope.  Those use chrome://settings-frame/display are not preferences, and look like we need specific implementation for display info.
Project Member

Comment 11 by bugdroid1@chromium.org, May 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/d3678f2e2e758a7fc2eed0c4c73a982fbd1e1a46

commit d3678f2e2e758a7fc2eed0c4c73a982fbd1e1a46
Author: Victor Hsieh <victorhsieh@chromium.org>
Date: Sun May 07 23:26:04 2017

Reimplement get_display_{modes,rotation}

Instead of inspecting internal Javascript variable in
chrome://settings-frame/display, use chrome.system.display.getInfo
to get display modes and rotation (Chrome OS only).

TEST=test_that -b caroline e:display_ResolutionList.* $DUT
     # PASSED, but seen flackiness on .mirrored
BUG= chromium:712705 
Change-Id: I521c425a0a3fbdfecbaf9df3b5abb46138013af9
Reviewed-on: https://chromium-review.googlesource.com/493925
Commit-Ready: Victor Hsieh <victorhsieh@chromium.org>
Tested-by: Victor Hsieh <victorhsieh@chromium.org>
Reviewed-by: Victor Hsieh <victorhsieh@chromium.org>

[modify] https://crrev.com/d3678f2e2e758a7fc2eed0c4c73a982fbd1e1a46/client/cros/multimedia/display_facade_native.py

Project Member

Comment 12 by bugdroid1@chromium.org, May 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84b76aa34b7ee89ea7b44af59239f6729aa53ab5

commit 84b76aa34b7ee89ea7b44af59239f6729aa53ab5
Author: victorhsieh <victorhsieh@chromium.org>
Date: Mon May 08 21:08:33 2017

Allow autotest extension to access system.display

system.display is currently only allowed for a few cases.  Grant
autotest extension to use the API for test purpose, too.

TEST=autotest works
BUG= 712705 

Review-Url: https://codereview.chromium.org/2862223003
Cr-Commit-Position: refs/heads/master@{#470124}

[modify] https://crrev.com/84b76aa34b7ee89ea7b44af59239f6729aa53ab5/extensions/browser/api/system_display/system_display_api.cc

Project Member

Comment 13 by bugdroid1@chromium.org, May 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04b4874993cea9341a2d3446bcc486f52916477c

commit 04b4874993cea9341a2d3446bcc486f52916477c
Author: afakhry <afakhry@chromium.org>
Date: Wed May 10 04:50:07 2017

Revert of Allow autotest extension to access system.display (patchset #1 id:1 of https://codereview.chromium.org/2862223003/ )

Reason for revert:
This causes a Chrome crash whenever you attempt to change anything in display settings. It assumes this is used from an extension.

Original issue's description:
> Allow autotest extension to access system.display
>
> system.display is currently only allowed for a few cases.  Grant
> autotest extension to use the API for test purpose, too.
>
> TEST=autotest works
> BUG= 712705 
>
> Review-Url: https://codereview.chromium.org/2862223003
> Cr-Commit-Position: refs/heads/master@{#470124}
> Committed: https://chromium.googlesource.com/chromium/src/+/84b76aa34b7ee89ea7b44af59239f6729aa53ab5

TBR=stevenjb@chromium.org,victorhsieh@google.com,victorhsieh@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 712705 , 719804 

Review-Url: https://codereview.chromium.org/2874633002
Cr-Commit-Position: refs/heads/master@{#470461}

[modify] https://crrev.com/04b4874993cea9341a2d3446bcc486f52916477c/extensions/browser/api/system_display/system_display_api.cc

Project Member

Comment 14 by bugdroid1@chromium.org, May 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90e6006c41c0013b8f48c02263e3a44c32da0c9c

commit 90e6006c41c0013b8f48c02263e3a44c32da0c9c
Author: victorhsieh <victorhsieh@chromium.org>
Date: Wed May 10 22:38:24 2017

Reland: Allow autotest extension to access system.display

system.display is currently only allowed for a few cases. Grant
autotest extension to use the API for test purpose, too.

TEST=Autotest works
TEST=Change display setting.  Did not crash with null check.
BUG= 719804 
BUG= 712705 

Review-Url: https://codereview.chromium.org/2874823002
Cr-Commit-Position: refs/heads/master@{#470737}

[modify] https://crrev.com/90e6006c41c0013b8f48c02263e3a44c32da0c9c/extensions/browser/api/system_display/system_display_api.cc

Project Member

Comment 15 by bugdroid1@chromium.org, May 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/bb990b6a2e3ca01ddf00256b85bb08dc2b1c17c2

commit bb990b6a2e3ca01ddf00256b85bb08dc2b1c17c2
Author: Victor Hsieh <victorhsieh@chromium.org>
Date: Thu May 18 02:06:24 2017

Stop control display via settings page

chrome.system.display.setDisplayProperties can do the job.  This API is
limited to some use case, so we need to allow autotest extension to use
it first.

TEST=test_that display_ResolutionList
TEST=test_that platform_RotationFps
TEST=test_that video_PlaybackQuality
TEST=test_that display_Tearing
TEST=test_that video_GlitchDetection (failed, but even w/o this change)
BUG= chromium:712705 

Change-Id: Ia45c6da7d72e2de5ebc8f01ca1124811f283b0f3
Reviewed-on: https://chromium-review.googlesource.com/498013
Commit-Ready: Victor Hsieh <victorhsieh@chromium.org>
Tested-by: Victor Hsieh <victorhsieh@chromium.org>
Reviewed-by: Victor Hsieh <victorhsieh@chromium.org>

[modify] https://crrev.com/bb990b6a2e3ca01ddf00256b85bb08dc2b1c17c2/server/site_tests/platform_RotationFps/platform_RotationFps.py
[modify] https://crrev.com/bb990b6a2e3ca01ddf00256b85bb08dc2b1c17c2/server/cros/multimedia/display_facade_adapter.py
[modify] https://crrev.com/bb990b6a2e3ca01ddf00256b85bb08dc2b1c17c2/client/cros/chameleon/chameleon_screen_test.py
[modify] https://crrev.com/bb990b6a2e3ca01ddf00256b85bb08dc2b1c17c2/server/site_tests/display_ResolutionList/display_ResolutionList.py
[modify] https://crrev.com/bb990b6a2e3ca01ddf00256b85bb08dc2b1c17c2/client/cros/multimedia/display_facade_adapter.py
[modify] https://crrev.com/bb990b6a2e3ca01ddf00256b85bb08dc2b1c17c2/server/site_tests/display_Tearing/display_Tearing.py
[modify] https://crrev.com/bb990b6a2e3ca01ddf00256b85bb08dc2b1c17c2/server/site_tests/video_PlaybackQuality/video_PlaybackQuality.py
[modify] https://crrev.com/bb990b6a2e3ca01ddf00256b85bb08dc2b1c17c2/client/site_tests/video_GlitchDetection/video_GlitchDetection.py
[modify] https://crrev.com/bb990b6a2e3ca01ddf00256b85bb08dc2b1c17c2/client/cros/multimedia/display_facade_native.py

Status: Fixed (was: Started)
Project Member

Comment 17 by bugdroid1@chromium.org, Jan 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/0ae21c779d7992cef2c6bdf83d4b7e360002245b

commit 0ae21c779d7992cef2c6bdf83d4b7e360002245b
Author: Wai-Hong Tam <waihong@google.com>
Date: Sun Jan 14 04:30:59 2018

chameleon: Raise error if Chrome API fails to set resolution/rotation

In the recent builds, the Chrome API seems to have an issue failing to
set resolution/rotation. Add check to catch this issue and raise an
error.

BUG= chromium:712705 
TEST=Run display_ResolutionList and get the TestFailed result:
RuntimeError: Failed to set resolution, result: None (RPC:
display.set_resolution)

Change-Id: I9eb7ddfc6b9847dcbb8268c342f1a5f3a657cc3a
Reviewed-on: https://chromium-review.googlesource.com/865637
Commit-Ready: Wai-Hong Tam <waihong@google.com>
Tested-by: Wai-Hong Tam <waihong@google.com>
Reviewed-by: Kalin Stoyanov <kalin@chromium.org>
Reviewed-by: Victor Hsieh <victorhsieh@chromium.org>

[modify] https://crrev.com/0ae21c779d7992cef2c6bdf83d4b7e360002245b/client/cros/multimedia/display_facade_native.py

Comment 18 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment