New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 712701 link

Starred by 1 user
Status: Verified
Owner:
jamescook@chromium.org
Closed: Apr 2017
Cc:
xiy...@chromium.org
█ tdander...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

System tray help and lock icons should not be enabled when creating supervised user

Project Member Reported by jamescook@chromium.org, Apr 18 2017 
Chrome ToT r464922

When creating a supervised user the primary user has logged in, but has no desktop or windows open. In this state the "Settings" icon is disabled in the system tray menu because we don't want to allows the settings window to open.

We should also disable the help and lock icons, since they don't work in this state.
supervised-user-help-enabled.png
664 KB View Download

Comment 1 by tdander...@chromium.org, Apr 18 2017

Labels: Proj-MaterialDesign-CrOS
Thanks for catching this, James!
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85312ee5ec5652a88b9b345d53f92ae261a0d451

commit 85312ee5ec5652a88b9b345d53f92ae261a0d451
Author: jamescook <jamescook@chromium.org>
Date: Tue Apr 18 22:47:20 2017

cros: Disable system tray help/lock buttons during supervised user creation

Neither button does anything during supervised user creation, so disable
them both.

Also disable settings buttons for Bluetooth and IME tray menu during this
flow, as those don't work either.

Clean up some cases where we were caching the login state and don't need to.

BUG= 712701 
TEST=ash_unittests, added TrayTilesTest.ButtonStatesSupervisedUserFlow,
manually check IME menu and bluetooth

Review-Url: https://codereview.chromium.org/2821363002
Cr-Commit-Position: refs/heads/master@{#465404}

[modify] https://crrev.com/85312ee5ec5652a88b9b345d53f92ae261a0d451/ash/system/bluetooth/tray_bluetooth.cc
[modify] https://crrev.com/85312ee5ec5652a88b9b345d53f92ae261a0d451/ash/system/date/system_info_default_view.cc
[modify] https://crrev.com/85312ee5ec5652a88b9b345d53f92ae261a0d451/ash/system/date/system_info_default_view.h
[modify] https://crrev.com/85312ee5ec5652a88b9b345d53f92ae261a0d451/ash/system/date/tray_system_info.cc
[modify] https://crrev.com/85312ee5ec5652a88b9b345d53f92ae261a0d451/ash/system/ime/tray_ime_chromeos.cc
[modify] https://crrev.com/85312ee5ec5652a88b9b345d53f92ae261a0d451/ash/system/ime_menu/ime_menu_tray.cc
[modify] https://crrev.com/85312ee5ec5652a88b9b345d53f92ae261a0d451/ash/system/tiles/tiles_default_view.cc
[modify] https://crrev.com/85312ee5ec5652a88b9b345d53f92ae261a0d451/ash/system/tiles/tiles_default_view.h
[modify] https://crrev.com/85312ee5ec5652a88b9b345d53f92ae261a0d451/ash/system/tiles/tray_tiles.cc
[modify] https://crrev.com/85312ee5ec5652a88b9b345d53f92ae261a0d451/ash/system/tiles/tray_tiles.h
[modify] https://crrev.com/85312ee5ec5652a88b9b345d53f92ae261a0d451/ash/system/tiles/tray_tiles_unittest.cc
[modify] https://crrev.com/85312ee5ec5652a88b9b345d53f92ae261a0d451/ash/system/tray/tray_details_view.cc
[modify] https://crrev.com/85312ee5ec5652a88b9b345d53f92ae261a0d451/ash/system/tray/tray_details_view.h
[modify] https://crrev.com/85312ee5ec5652a88b9b345d53f92ae261a0d451/ash/system/tray/tray_popup_utils.cc
[modify] https://crrev.com/85312ee5ec5652a88b9b345d53f92ae261a0d451/ash/system/tray/tray_popup_utils.h
[modify] https://crrev.com/85312ee5ec5652a88b9b345d53f92ae261a0d451/ash/system/tray_accessibility.cc
[modify] https://crrev.com/85312ee5ec5652a88b9b345d53f92ae261a0d451/ash/system/tray_accessibility.h
[modify] https://crrev.com/85312ee5ec5652a88b9b345d53f92ae261a0d451/ash/test/test_session_controller_client.cc
[modify] https://crrev.com/85312ee5ec5652a88b9b345d53f92ae261a0d451/ash/test/test_session_controller_client.h
[modify] https://crrev.com/85312ee5ec5652a88b9b345d53f92ae261a0d451/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc

Comment 3 by jamescook@chromium.org, Apr 18 2017

Status: Fixed (was: Started)

Comment 4 by abod...@chromium.org, May 8 2017

Status: Verified (was: Fixed)
Chrome OS 9532.0.0, 60.0.3092.0
►

Sign in to add a comment