New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 712694 link

Starred by 2 users
Status: Fixed
Owner: ----
Closed: Oct 2017
Cc:
perezju@chromium.org
█ nednguyen@chromium.org
sullivan@chromium.org
nedngu...@google.com
█ rnep...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 713222


Sign in to add a comment

Disabling webGL stories when running on bots that do not support webGL.

Project Member Reported by mythria@chromium.org, Apr 18 2017 
I was looking at this failure on the new maps page that I included in the system health's browse story set: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/433158.

This test runs fine locally, but when I use xvfb-run the test fails with the same error. I assume this is because of the lack of webGL support. 

How do we disable such stories when webGL is not supported. For example, something similar to what the maps page does here: https://cs.chromium.org/chromium/src/tools/perf/page_sets/maps.py?q=maps.py+package:%5Echromium$&l=18

Comment 1 by nedngu...@google.com, Apr 18 2017

Cc: rnep...@chromium.org
We should be overriding page.CanRunOnBrowser to use those same code, but we are already use that method for specifying whether a story should be enabled or not :-(

I think the action items here could be:
1) Wait for Randy to implement a new disabling-per-story system
2) Remove the disabling code in the current system health stories
3) Override MapPage.CanRunOnBrowser to use the webgl check

Comment 2 by mythria@chromium.org, Apr 19 2017 

What is the approximate timeline for this new system? If there is a bug already, just so I can make this bug blocked on it.

Comment 3 by rnep...@chromium.org, Apr 19 2017

Blockedon: 713222

Comment 4 by nedngu...@google.com, May 11 2017

Cc: sullivan@chromium.org nedngu...@google.com
 Issue 721168  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e53c321b037ef376a88b47c720d95f16315b0b39

commit e53c321b037ef376a88b47c720d95f16315b0b39
Author: Mythri Alle <mythria@chromium.org>
Date: Thu Sep 07 10:05:38 2017

Enable maps and earth stories in system health browse page set

Maps and earth stories are disabled because there was no way to skip
them on platforms that do not have webGL support. Now we can use
CanRunOnBrowser to perform the webGL check. This cl adds the webGL
check and enables maps and earth stories in system health browse
page set.

Bug:  chromium:712694 
Change-Id: Idac869b61ffb9febcba02593033fcdf762158b8b
Reviewed-on: https://chromium-review.googlesource.com/635587
Commit-Queue: Mythri Alle <mythria@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500263}
[modify] https://crrev.com/e53c321b037ef376a88b47c720d95f16315b0b39/tools/perf/page_sets/system_health/browsing_stories.py
[modify] https://crrev.com/e53c321b037ef376a88b47c720d95f16315b0b39/tools/perf/page_sets/system_health/expectations.py
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7c2478a9d32c09251bd2ec0e2a2cd92134d9c0d

commit c7c2478a9d32c09251bd2ec0e2a2cd92134d9c0d
Author: Charlie Andrews <charliea@chromium.org>
Date: Thu Sep 07 20:41:20 2017

Disable v8.browsing_desktop browse:tools:earth and maps

They were reenabled yesterday in crrev.com/c/635587, but are still
failing across desktop platforms.

TBR=nednguyen@google.com, mythria@chromium.org

Bug: 708590,  712694 ,  763029 
Change-Id: Ie897089f88118f043a20279e7a63f42c30a86735
Reviewed-on: https://chromium-review.googlesource.com/655808
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500372}
[modify] https://crrev.com/c7c2478a9d32c09251bd2ec0e2a2cd92134d9c0d/tools/perf/page_sets/system_health/expectations.py

Comment 7 by mythria@chromium.org, Oct 12 2017

Status: Fixed (was: Available)
This is now done.

Comment 8 by benhenry@google.com, Jan 16

Components: Test>Telemetry

Comment 9 by benhenry@google.com, Jan 16

Components: -Speed>Telemetry
►

Sign in to add a comment