New issue
Advanced search Search tips

Issue 712689 link

Starred by 1 user
Status: Fixed
Owner:
mdjones@chromium.org
Closed: Jun 2017
Cc:
twelling...@chromium.org
mdjones@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: ----



Sign in to add a comment

[Home] Properly color pull handle when bottom sheet contents are changed

Project Member Reported by twelling...@chromium.org, Apr 18 2017 
The pull handle color needs be adjusted when the toolbar color changes due to changing the bottom sheet content (e.g. on incognito select history), when selection mode is activated on history/downloads/bookmarks or when searching on history/downloads bookmarks. Matt and I had discussed in the past creating a mechanism for notifying the bottom sheet that the toolbar color had changed.

Comment 1 by twelling...@chromium.org, Apr 18 2017 

The handle was initially added in issue 692865

Comment 2 by twelling...@chromium.org, Apr 18 2017

Labels: -Restrict-View-Google

Comment 3 by mdjones@chromium.org, Apr 18 2017

Owner: mdjones@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3de25d5d2440ec1df7c04ec0b3fa639450bd6105

commit 3de25d5d2440ec1df7c04ec0b3fa639450bd6105
Author: mdjones <mdjones@chromium.org>
Date: Thu Apr 20 22:28:23 2017

[Home] Allow bottom sheet content to update handle color

This change adds some plumbing to allow the toolbars of the bottom
sheet to update the handle color based on their state. The
BottomSheetContent interface has been updated to allow the bottom
sheet to query the current handle color if a custom toolbar is
showing and each toolbar has a reference to the bottom sheet to
request an update.

BUG= 712689 

Review-Url: https://codereview.chromium.org/2833573002
Cr-Commit-Position: refs/heads/master@{#466164}

[modify] https://crrev.com/3de25d5d2440ec1df7c04ec0b3fa639450bd6105/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkManager.java
[modify] https://crrev.com/3de25d5d2440ec1df7c04ec0b3fa639450bd6105/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkSheetContent.java
[modify] https://crrev.com/3de25d5d2440ec1df7c04ec0b3fa639450bd6105/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSheetContent.java
[modify] https://crrev.com/3de25d5d2440ec1df7c04ec0b3fa639450bd6105/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java
[modify] https://crrev.com/3de25d5d2440ec1df7c04ec0b3fa639450bd6105/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManager.java
[modify] https://crrev.com/3de25d5d2440ec1df7c04ec0b3fa639450bd6105/chrome/android/java/src/org/chromium/chrome/browser/history/HistorySheetContent.java
[modify] https://crrev.com/3de25d5d2440ec1df7c04ec0b3fa639450bd6105/chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoBottomSheetContent.java
[modify] https://crrev.com/3de25d5d2440ec1df7c04ec0b3fa639450bd6105/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetContent.java
[modify] https://crrev.com/3de25d5d2440ec1df7c04ec0b3fa639450bd6105/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarPhone.java
[modify] https://crrev.com/3de25d5d2440ec1df7c04ec0b3fa639450bd6105/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java
[modify] https://crrev.com/3de25d5d2440ec1df7c04ec0b3fa639450bd6105/chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableListLayout.java
[modify] https://crrev.com/3de25d5d2440ec1df7c04ec0b3fa639450bd6105/chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableListToolbar.java

Comment 5 by mdjones@chromium.org, Jun 5 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment