New issue
Advanced search Search tips

Issue 712688 link

Starred by 1 user
Status: Fixed
Owner:
robertogden@chromium.org
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Restructure ChromeProxy integration tests

Project Member Reported by robertogden@chromium.org, Apr 18 2017 
Now that we've got most of the tests written, we can clean them up a little.

Proposed changes:
1) Refactor decorators into their own class
2) Add decorators to detect and skip tests based on Chrome version
3) Separate large and small tests into different directories
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9378ff37d394367870aec12cef1c9ee42633fe39

commit 9378ff37d394367870aec12cef1c9ee42633fe39
Author: robertogden <robertogden@chromium.org>
Date: Fri Apr 21 18:07:47 2017

Add Chrome version check decorators

Uses lazy loading to only get the version when needed, and uses a global
variable (yuck) to store it for all future test runs.

BUG= 712688 

Review-Url: https://codereview.chromium.org/2826733002
Cr-Commit-Position: refs/heads/master@{#466390}

[modify] https://crrev.com/9378ff37d394367870aec12cef1c9ee42633fe39/tools/chrome_proxy/webdriver/decorator_smoke.py
[modify] https://crrev.com/9378ff37d394367870aec12cef1c9ee42633fe39/tools/chrome_proxy/webdriver/decorators.py

Comment 4 by robertogden@chromium.org, Apr 21 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment