New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 712675 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Integer-overflow in SkIRect::width

Project Member Reported by ClusterFuzz, Apr 18 2017

Issue description

Cc: msrchandra@chromium.org
Components: Internals>Skia
Labels: M-60 Test-Predator-Wrong-CLs
Owner: hidehiko@chromium.org
Status: Assigned (was: Untriaged)
Predator did not provide any possible suspects.
Assigning to the concern owner from the below CL --
https://chromium.googlesource.com/chromium/src/+log/5f12b627c3a67b59f3a42a3374b3255ebe1abe19..ddefb10bee663f8d240c999309f37cc2f96d2e92?pretty=fuller

Suspecting Commit#
https://chromium.googlesource.com/chromium/src/+/ddefb10bee663f8d240c999309f37cc2f96d2e92

@hidehiko -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.
Cc: hidehiko@chromium.org
Owner: enne@chromium.org
That is just a revert CL because of test breakage.
Reassigned to enne@, who's the original author.

Comment 3 by enne@chromium.org, Apr 18 2017

Cc: reed@google.com
Owner: mtklein@chromium.org
If a revert revealed this, then this is likely a long standing bug.  That code stopped being run in the patch and started being reused in the revert.

Handing to mtklein.  I don't know if Skia WontFixes this sort of thing, but just FYI.

Comment 4 by hcm@chromium.org, Apr 18 2017

Labels: -Pri-2 Pri-3
Skia at least decreases priority on these non-security int overflows... if someone has an idea and quick fix, awesome, but these come and go and often cannot be prioritized with other work.
Project Member

Comment 5 by ClusterFuzz, May 2 2017

ClusterFuzz has detected this issue as fixed in range 468540:468550.

Detailed report: https://clusterfuzz.com/testcase?key=4816282605322240

Fuzzer: miaubiz_svg_fuzzer
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  SkIRect::width
  SkNoPixelsDevice::resetForNextPicture
  SkCanvas::resetForNextPicture
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=465194:465196
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=468540:468550

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4816282605322240


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, May 2 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 4816282605322240 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment