Rewrite doins/dodir for performance. |
|||||||
Issue descriptionOS: ChromeOS. In some cases, doins/dodir take long time. An example is crbug.com/710831. Copy the experimental result of rewrting them in python from its #0; -- with doins.py (experiment) real 0m52.543s user 3m9.080s sys 0m24.628s -- with doins (control) real 4m22.780s user 4m7.872s sys 1m43.860s so, it may have more performance benefit for other builds, too.
,
May 3 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/manifest-internal/+/3cff6fd3ee69bcb3ccb85669c960001588f71e74 commit 3cff6fd3ee69bcb3ccb85669c960001588f71e74 Author: Hidehiko Abe <hidehiko@chromium.org> Date: Wed May 03 17:38:25 2017
,
May 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/manifest/+/cc724fe3496c5c7a85022f3d45e32308d3f2ca00 commit cc724fe3496c5c7a85022f3d45e32308d3f2ca00 Author: Hidehiko Abe <hidehiko@chromium.org> Date: Wed May 03 17:38:25 2017 Add portage_tool third_party repository. CQ-DEPEND=CL:*364848 BUG= chromium:712659 TEST=n/a Change-Id: Ib57d6e8e7366d694558a237e012e41512dc058f9 Reviewed-on: https://chromium-review.googlesource.com/491206 Commit-Ready: Hidehiko Abe <hidehiko@chromium.org> Tested-by: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/cc724fe3496c5c7a85022f3d45e32308d3f2ca00/full.xml
,
May 31 2017
,
Jun 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/50cf67412653ed1356d191386e015c05ba5c52a6 commit 50cf67412653ed1356d191386e015c05ba5c52a6 Author: Mike Frysinger <vapier@chromium.org> Date: Fri Jun 02 23:59:40 2017 portage: switch to cros-workon Now that we have portage checked out in our manifest, we can switch from manual patching to a cros-workon package. This will make it easier to manage updates. BUG= chromium:712659 TEST=precq passes Change-Id: Iecda46f5cc858196de52e284a04c58240ddfd9ea Reviewed-on: https://chromium-review.googlesource.com/509211 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> [add] https://crrev.com/50cf67412653ed1356d191386e015c05ba5c52a6/sys-apps/portage/files/chromeos-version.sh [delete] https://crrev.com/f639a775426e79fe09d50a1137593c60cf3e18a1/sys-apps/portage/Manifest [copy] https://crrev.com/50cf67412653ed1356d191386e015c05ba5c52a6/sys-apps/portage/portage-2.2.12-r10.ebuild [rename] https://crrev.com/50cf67412653ed1356d191386e015c05ba5c52a6/sys-apps/portage/portage-9999.ebuild [delete] https://crrev.com/f639a775426e79fe09d50a1137593c60cf3e18a1/sys-apps/portage/portage-2.2.12-r9.ebuild [delete] https://crrev.com/f639a775426e79fe09d50a1137593c60cf3e18a1/sys-apps/portage/files/2.2.12-r9.patch
,
Jul 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b87618142279f2c84dd02bc21cf58e970413373 commit 5b87618142279f2c84dd02bc21cf58e970413373 Author: Hidehiko Abe <hidehiko@chromium.org> Date: Thu Jul 06 15:00:57 2017 Move SetProfile just before BrowserContextKeyedService construction. This is preparation to replace ArcService by BrowserContextKeyedService. With this CL, it is ensured that a Profile is set to ARC when BrowserContextKeyedService is being constructed. BUG= 712659 TEST=Ran trybot. Ran on DUT. Change-Id: Ia040e9aeda354c6c198fd65e28fe257f3c3697c3 Reviewed-on: https://chromium-review.googlesource.com/559629 Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: Anthony Vallee-Dubois <anthonyvd@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Yusuke Sato <yusukes@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#484594} [modify] https://crrev.com/5b87618142279f2c84dd02bc21cf58e970413373/chrome/browser/chromeos/arc/arc_service_launcher.cc [modify] https://crrev.com/5b87618142279f2c84dd02bc21cf58e970413373/chrome/browser/chromeos/arc/arc_service_launcher.h [modify] https://crrev.com/5b87618142279f2c84dd02bc21cf58e970413373/chrome/browser/chromeos/arc/arc_session_manager.cc [modify] https://crrev.com/5b87618142279f2c84dd02bc21cf58e970413373/chrome/browser/chromeos/arc/arc_session_manager_browsertest.cc [modify] https://crrev.com/5b87618142279f2c84dd02bc21cf58e970413373/chrome/browser/chromeos/arc/auth/arc_active_directory_enrollment_token_fetcher_browsertest.cc [modify] https://crrev.com/5b87618142279f2c84dd02bc21cf58e970413373/chrome/browser/chromeos/arc/auth/arc_auth_service_browsertest.cc [modify] https://crrev.com/5b87618142279f2c84dd02bc21cf58e970413373/chrome/browser/chromeos/profiles/profile_helper.h [modify] https://crrev.com/5b87618142279f2c84dd02bc21cf58e970413373/chrome/browser/profiles/profile_impl.cc [modify] https://crrev.com/5b87618142279f2c84dd02bc21cf58e970413373/chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.cc [modify] https://crrev.com/5b87618142279f2c84dd02bc21cf58e970413373/chrome/browser/ui/ash/launcher/arc_app_launcher_browsertest.cc [modify] https://crrev.com/5b87618142279f2c84dd02bc21cf58e970413373/chrome/test/base/testing_profile.cc
,
Oct 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/portage_tool/+/5210635496db76cc37c94a7ef351776914000e47 commit 5210635496db76cc37c94a7ef351776914000e47 Author: Mike Frysinger <vapier@chromium.org> Date: Fri Oct 13 21:45:21 2017 disable various preupload tests Since this is an upstream repo, we don't want to enforce certain license/style checks like we would in a source repo we wrote. BUG= chromium:712659 TEST=uploading works again Change-Id: Icd44f6e926b241d9d431d0e18c739754a64fc859 Reviewed-on: https://chromium-review.googlesource.com/538253 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> [add] https://crrev.com/5210635496db76cc37c94a7ef351776914000e47/PRESUBMIT.cfg
,
Nov 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/portage_tool/+/dd8ad7251ab85091ebcac11b721eb82e21d82256 commit dd8ad7251ab85091ebcac11b721eb82e21d82256 Author: Hidehiko Abe <hidehiko@chromium.org> Date: Wed Nov 22 07:55:31 2017 Rewrite doins by python. doins is written in bash. However, specifically in case that too many files are installed, it is very slow. This CL rewrites the script in python for performance. BUG= chromium:712659 TEST=time (./setup_board --force && \ ./build_package --withdev && \ ./build_image --noenable_rootfs_verification test) ===Before=== real 21m35.445s user 93m40.588s sys 21m31.224s ===After=== real 17m30.106s user 94m1.812s sys 20m13.468s Change-Id: Ib10f623961ba316753d58397cff5e72fbc343339 Reviewed-on: https://chromium-review.googlesource.com/559225 Commit-Ready: Hidehiko Abe <hidehiko@chromium.org> Tested-by: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [add] https://crrev.com/dd8ad7251ab85091ebcac11b721eb82e21d82256/pym/portage/tests/bin/test_doins.py [modify] https://crrev.com/dd8ad7251ab85091ebcac11b721eb82e21d82256/bin/ebuild-helpers/doins [add] https://crrev.com/dd8ad7251ab85091ebcac11b721eb82e21d82256/bin/doins.py
,
Dec 8 2017
,
Dec 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/portage_tool/+/e5e0941c9f08f32425e8485032eadb51239c8ad2 commit e5e0941c9f08f32425e8485032eadb51239c8ad2 Author: Zac Medico <zmedico@gentoo.org> Date: Tue Dec 12 14:25:44 2017 bin/doins.py: remove file before creating symlink (bug 640376) Fixes: d9522ba661b5 ("Rewrite doins in python ( bug 624526 )") Bug: https://bugs.gentoo.org/640376 (cherry picked from commit 992b4ffdcbf469db543c9cab90a5f7a3a4125c97) BUG= chromium:712659 TEST=precq passes Change-Id: I2f3361aeaeed16e1c857881e25bf12c9c3f8eb91 Reviewed-on: https://chromium-review.googlesource.com/820199 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> [modify] https://crrev.com/e5e0941c9f08f32425e8485032eadb51239c8ad2/bin/doins.py
,
Dec 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/portage_tool/+/d10e79ca26d87a880505a50740715a4cd0cb67aa commit d10e79ca26d87a880505a50740715a4cd0cb67aa Author: Mike Frysinger <vapier@chromium.org> Date: Wed Dec 13 22:27:40 2017 disable various preupload tests Since this is an upstream repo, we don't want to enforce certain license/style checks like we would in a source repo we wrote. BUG= chromium:712659 TEST=uploading works again https://chromium-review.googlesource.com/538253 Change-Id: Icd44f6e926b241d9d431d0e18c739754a64fc859 Reviewed-on: https://chromium-review.googlesource.com/815666 Commit-Queue: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> [add] https://crrev.com/d10e79ca26d87a880505a50740715a4cd0cb67aa/PRESUBMIT.cfg
,
Dec 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/portage_tool/+/79564edd386e7f99bff6127a0279291441a1ddf0 commit 79564edd386e7f99bff6127a0279291441a1ddf0 Author: Hidehiko Abe <hidehiko@chromium.org> Date: Wed Dec 13 22:27:43 2017 Rewrite doins by python. doins is written in bash. However, specifically in case that too many files are installed, it is very slow. This CL rewrites the script in python for performance. BUG= chromium:712659 TEST=time (./setup_board --force && \ ./build_package --withdev && \ ./build_image --noenable_rootfs_verification test) ===Before=== real 21m35.445s user 93m40.588s sys 21m31.224s ===After=== real 17m30.106s user 94m1.812s sys 20m13.468s https://chromium-review.googlesource.com/559225 Change-Id: Ib10f623961ba316753d58397cff5e72fbc343339 Reviewed-on: https://chromium-review.googlesource.com/815667 Commit-Queue: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> [add] https://crrev.com/79564edd386e7f99bff6127a0279291441a1ddf0/pym/portage/tests/bin/test_doins.py [modify] https://crrev.com/79564edd386e7f99bff6127a0279291441a1ddf0/bin/ebuild-helpers/doins [add] https://crrev.com/79564edd386e7f99bff6127a0279291441a1ddf0/bin/doins.py
,
Dec 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/portage_tool/+/c41e9f4aedab8e8c6010b9d7549c85a53990ed85 commit c41e9f4aedab8e8c6010b9d7549c85a53990ed85 Author: Zac Medico <zmedico@gentoo.org> Date: Thu Dec 14 16:38:57 2017 bin/doins.py: remove file before creating symlink (bug 640376) Fixes: d9522ba661b5 ("Rewrite doins in python ( bug 624526 )") Bug: https://bugs.gentoo.org/640376 (cherry picked from commit 992b4ffdcbf469db543c9cab90a5f7a3a4125c97) BUG= chromium:712659 TEST=precq passes https://chromium-review.googlesource.com/820199 Change-Id: I2f3361aeaeed16e1c857881e25bf12c9c3f8eb91 Reviewed-on: https://chromium-review.googlesource.com/826164 Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/c41e9f4aedab8e8c6010b9d7549c85a53990ed85/bin/doins.py
,
Dec 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/portage_tool/+/2d106af1ab8026661a35f5b218c67f6f5b485a8c commit 2d106af1ab8026661a35f5b218c67f6f5b485a8c Author: Zac Medico <zmedico@gentoo.org> Date: Mon Dec 18 15:02:30 2017 bin/ebuild-helpers/doins: fix PYTHONPATH setting (bug 640934) This makes the PYTHONPATH setting consistent with other helpers like dohtml and xattr/install. Fixes: d9522ba661b5 ("Rewrite doins in python ( bug 624526 )") Bug: https://bugs.gentoo.org/640934 (cherry picked from commit 7ae0c9d084bb1caf18c751cecb7fb98a619dfbcb) BUG= chromium:712659 TEST=precq passes Change-Id: Ie7c5520665e3be9c6d90f68a2614096ec75814a3 Reviewed-on: https://chromium-review.googlesource.com/831070 Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/2d106af1ab8026661a35f5b218c67f6f5b485a8c/bin/ebuild-helpers/doins
,
Dec 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/portage_tool/+/841913eb215bdc7439a30f5992c118ea3cd1bee7 commit 841913eb215bdc7439a30f5992c118ea3cd1bee7 Author: Zac Medico <zmedico@gentoo.org> Date: Tue Dec 19 04:32:58 2017 bin/ebuild-helpers/doins: fix PYTHONPATH setting (bug 640934) This makes the PYTHONPATH setting consistent with other helpers like dohtml and xattr/install. Fixes: d9522ba661b5 ("Rewrite doins in python ( bug 624526 )") Bug: https://bugs.gentoo.org/640934 (cherry picked from commit 7ae0c9d084bb1caf18c751cecb7fb98a619dfbcb) BUG= chromium:712659 TEST=precq passes Change-Id: Ie7c5520665e3be9c6d90f68a2614096ec75814a3 Reviewed-on: https://chromium-review.googlesource.com/831071 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> [modify] https://crrev.com/841913eb215bdc7439a30f5992c118ea3cd1bee7/bin/ebuild-helpers/doins
,
Jul 30
,
Dec 13
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/portage_tool/+/fb46c2bc3b09c8be28f97f0be49e7166bd70889b commit fb46c2bc3b09c8be28f97f0be49e7166bd70889b Author: Mike Frysinger <vapier@chromium.org> Date: Thu Dec 13 21:05:36 2018 disable various preupload tests Since this is an upstream repo, we don't want to enforce certain license/style checks like we would in a source repo we wrote. BUG= chromium:712659 TEST=uploading works again https://chromium-review.googlesource.com/538253 https://chromium-review.googlesource.com/815666 Change-Id: I227cfca937832c75181477d4a08e2c88cbbb7a47 Reviewed-on: https://chromium-review.googlesource.com/c/1377097 Tested-by: Allen Webb <allenwebb@google.com> Reviewed-by: Mike Frysinger <vapier@chromium.org> Commit-Queue: Allen Webb <allenwebb@google.com> [add] https://crrev.com/fb46c2bc3b09c8be28f97f0be49e7166bd70889b/PRESUBMIT.cfg |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, May 3 2017