New issue
Advanced search Search tips

Issue 712651 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

The WebRTC echo canceller 3 sometimes has poor transparency when there is weak, or no, echo

Project Member Reported by peah@chromium.org, Apr 18 2017

Issue description

The WebRTC echo canceller 3 sometimes has poor transparency when there is weak, or no, echo.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/e52a203a56c7876bc226c04464563555433fa0c1

commit e52a203a56c7876bc226c04464563555433fa0c1
Author: peah <peah@webrtc.org>
Date: Wed Apr 19 16:03:40 2017

Echo canceller 3 improvements for setups with headsets.

This CL improves the echo cancellation performance on setups where
headsets are used (systems with such low echo path gain
that no correlation between the render and capture signals
can be found) in 4 ways:
1) The echo path gain for systems with headsets is assumed to be
nonzero.
2) The stationary component of the render power is not included
in nonlinear echo power estimate.
3) The behavior after echo path gain changes is made less cautious.
4) The detection of systems with headsets is made more rapid.

BUG= chromium:712651 ,  webrtc:6018 

Review-Url: https://codereview.webrtc.org/2823903003
Cr-Commit-Position: refs/heads/master@{#17768}

[modify] https://crrev.com/e52a203a56c7876bc226c04464563555433fa0c1/webrtc/modules/audio_processing/aec3/aec_state.cc
[modify] https://crrev.com/e52a203a56c7876bc226c04464563555433fa0c1/webrtc/modules/audio_processing/aec3/aec_state.h
[modify] https://crrev.com/e52a203a56c7876bc226c04464563555433fa0c1/webrtc/modules/audio_processing/aec3/residual_echo_estimator.cc
[modify] https://crrev.com/e52a203a56c7876bc226c04464563555433fa0c1/webrtc/modules/audio_processing/aec3/residual_echo_estimator.h

Comment 2 by peah@chromium.org, Apr 23 2017

Labels: Merge-Request-59
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 23 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, Apr 26 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by peah@chromium.org, Apr 27 2017

Labels: merge-merged-59
Project Member

Comment 6 by sheriffbot@chromium.org, May 1 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by peah@chromium.org, May 3 2017

Labels: -Hotlist-Merge-Approved -Merge-Approved-59

Comment 8 by peah@chromium.org, May 3 2017

Status: Fixed (was: Assigned)

Sign in to add a comment