One of the errors says:
"
Uninitialized value was created by an allocation of 'params_in' in the stack frame of function '_ZN10extensions47ExtensionMessageTypesTest_TestLoadedParams_Test8TestBodyEv'
#0 0xc9f950 in extensions::ExtensionMessageTypesTest_TestLoadedParams_Test::TestBody() extensions/common/extension_messages_unittest.cc:41:0
"
params_in is a variable of type ExtensionMsg_Loaded_Params defined as:
ExtensionMsg_Loaded_Params params_in(extension.get(), true);
That particular constructor seems to initialize all fields in the struct.
I am not able to tell whether the MSan warning is real or false positive, but actually r464954, which is almost in the blamelist intersection, seems to have touched those files. I'll spend some more time looking into this as a sheriff, but already Cc-ing the CL's author and approvers to allow them have a look.
I left a comment on the CL https://codereview.chromium.org/2499493004/#msg124 but I'm not really sure whether that suggestion is what MSan points out.
I need to move on with sheriffing, so would appreciate a hand from some of you. Thanks!
Thank you for the quick response!
I'm not even sure yet whether your CL is really the culprit, because the bots are so slow they did not even started building with the revert yet.
I am now at the end of my sheriff shift, so won't be able to look further. Feel free to address this as you see fit, including relanding your CL as it was in case the bots (linked from #0) don't get better after processing the revert.
CL with fix under review at https://codereview.chromium.org/2833843004/
Tested locally with MSAN build which passes. I don't access to submit jobs to chromium.memory try servers however.
Comment 1 by vabr@chromium.org
, Apr 18 2017Components: -Internals>Core Platform>Extensions
Status: Available (was: Untriaged)
One of the errors says: " Uninitialized value was created by an allocation of 'params_in' in the stack frame of function '_ZN10extensions47ExtensionMessageTypesTest_TestLoadedParams_Test8TestBodyEv' #0 0xc9f950 in extensions::ExtensionMessageTypesTest_TestLoadedParams_Test::TestBody() extensions/common/extension_messages_unittest.cc:41:0 " params_in is a variable of type ExtensionMsg_Loaded_Params defined as: ExtensionMsg_Loaded_Params params_in(extension.get(), true); That particular constructor seems to initialize all fields in the struct. I am not able to tell whether the MSan warning is real or false positive, but actually r464954, which is almost in the blamelist intersection, seems to have touched those files. I'll spend some more time looking into this as a sheriff, but already Cc-ing the CL's author and approvers to allow them have a look.