New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 712629 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

"virtual/gpu/fast/canvas/canvas-imageSmoothingQuality-pixel.html" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Apr 18 2017

Issue description

"virtual/gpu/fast/canvas/canvas-imageSmoothingQuality-pixel.html" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNySgsSBUZsYWtlIj92aXJ0dWFsL2dwdS9mYXN0L2NhbnZhcy9jYW52YXMtaW1hZ2VTbW9vdGhpbmdRdWFsaXR5LXBpeGVsLmh0bWwM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 

Comment 1 by vabr@chromium.org, Apr 18 2017

This seems to be crashing. The logs contain this:

02:04:17.041 2941 worker/6 virtual/gpu/fast/canvas/canvas-imageSmoothingQuality-pixel.html crashed, (stderr lines):
02:04:17.042 2941   Xlib:  extension "RANDR" missing on display ":99".
02:04:17.042 2941   [1:1:0418/020416.748103:523137110:INFO:GrContext.cpp(919)] ../../third_party/skia/src/gpu/GrContext.cpp:919: fatal error: "assert(fDidTestPMConversions)"

Comment 2 by vabr@chromium.org, Apr 18 2017

Cc: zakerinasab@chromium.org
Components: Internals>GPU>Canvas2D
Labels: -Sheriff-Chromium OS-Linux
https://codereview.chromium.org/2824703005/ is disabling this test.

zakerinasab@ -- as the owner of  bug 693568 , would you know where to route this one to?
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/635f99993284f12c5c7eebab03446ef5cd2733ac

commit 635f99993284f12c5c7eebab03446ef5cd2733ac
Author: vabr <vabr@chromium.org>
Date: Tue Apr 18 15:13:28 2017

Mark virtual/gpu/fast/canvas/canvas-imageSmoothingQuality-pixel.html as crashing on Linux

This test is reported flaky in  https://crbug.com/712629 , and the failures are only on Linux and appear to be crashes.

BUG= 712629 
TBR=zakerinasab@chromium.org

Review-Url: https://codereview.chromium.org/2824703005
Cr-Commit-Position: refs/heads/master@{#465240}

[modify] https://crrev.com/635f99993284f12c5c7eebab03446ef5cd2733ac/third_party/WebKit/LayoutTests/TestExpectations

Comment 4 by ericrk@chromium.org, Apr 18 2017

Owner: zakerinasab@chromium.org
Status: Assigned (was: Untriaged)
per #2, assigning to zakerinasab@ for triage? Thanks!
Components: Internals>GPU>Rasterization
Owner: ----
Status: Untriaged (was: Assigned)
I tagged the bug with Internals>GPU>Rasterization to see if someone can triage the bug there.
All the crashes happen on SkASSERT(fDidTestPMConversions) in GrContext::createPMToUPMEffect():
https://cs.chromium.org/chromium/src/third_party/skia/src/gpu/GrContext.cpp?q=GrContext.cpp+package:%5Echromium$&l=898
Owner: bsalomon@chromium.org
Status: Assigned (was: Untriaged)
bsalomon@: can you take a look and triage?

Comment 10 by junov@chromium.org, Apr 24 2017

Components: -Internals>GPU>Canvas2D -Internals>GPU>Rasterization Blink>Canvas Internals>Skia
Cc: bsalomon@chromium.org
Owner: brianosman@chromium.org
brianosman@ has been making changes in this code recently.
I expected this to be fixed by https://skia-review.googlesource.com/c/13962/

From looking at the link to recent flakes in the original bug, it seems like the flakes stopped after that landed?
It seems so. I go ahead and remove the crash tag from test expectations. I hope the flaky behavior doesn't come back :)
Project Member

Comment 14 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de1aa71cbaa27e66039ca786106b66cb3ebf0965

commit de1aa71cbaa27e66039ca786106b66cb3ebf0965
Author: zakerinasab <zakerinasab@chromium.org>
Date: Wed Apr 26 16:58:31 2017

Removing crash tag for canvas-imageSmoothingQuality-pixel.html

Removing crash tag for "virtual/gpu/fast/canvas/canvas-imageSmoothingQuality-pixel.html"
layout test from TestExpectations as according to
https://bugs.chromium.org/p/chromium/issues/detail?id=712629#c12
the bug is fixed in https://skia-review.googlesource.com/c/13962/.

BUG= 712629 

Review-Url: https://codereview.chromium.org/2845663002
Cr-Commit-Position: refs/heads/master@{#467351}

[modify] https://crrev.com/de1aa71cbaa27e66039ca786106b66cb3ebf0965/third_party/WebKit/LayoutTests/TestExpectations

Status: Fixed (was: Assigned)

Sign in to add a comment