Auto reload crashes |
||||||
Issue descriptionChrome Version: M60 What steps will reproduce the problem? (1) Enable the auto reload in experimental setting (2) Load one or two pages with network (3) Enable airplane mode (4) Load a page What is the expected result? The page should be reloaded when the airplane mode goes off. What happens instead? Application crashes Repro 3/5 times. This bug is present in M59 and M60 at least.
,
Apr 19 2017
,
Apr 19 2017
,
Apr 19 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55deab02f85ce0b14e91ed14780d35aca6fdb8ff commit 55deab02f85ce0b14e91ed14780d35aca6fdb8ff Author: gambard <gambard@chromium.org> Date: Wed Apr 19 15:30:40 2017 Fix reload in AutoReload When the -reload method of tab was removed, AutoReloadBridge was not updated. This CL uses the new method to reload the tab. BUG= 712614 Review-Url: https://codereview.chromium.org/2826593003 Cr-Commit-Position: refs/heads/master@{#465527} (cherry picked from commit 156fad6be9bcf46c9c312fa7da92fd97b48e4bc6) Review-Url: https://codereview.chromium.org/2826123002 . Cr-Commit-Position: refs/branch-heads/3071@{#49} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/55deab02f85ce0b14e91ed14780d35aca6fdb8ff/ios/chrome/browser/web/BUILD.gn [modify] https://crrev.com/55deab02f85ce0b14e91ed14780d35aca6fdb8ff/ios/chrome/browser/web/auto_reload_bridge.mm
,
Apr 25 2017
https://drive.google.com/open?id=0B6GVWQnhaMClWGdrMWdEQ2xkc2s Verified on iPhone 6+ iOS 10.2.1, iPad iOS 10.2.1 build 60.0.3080.0 Canary
,
Apr 26 2017
Verified the issue on the build 59.0.3071.27 beta tested on iPhone7+. App doesn't crashes with the above steps works fine.
,
Apr 26 2017
App is not crashing but also the expected behavior from original bug report is not achieved. The page is not reloaded when connecting back to internet. Steps: 1. Turn OFF wifi. 2. Tap Menu --> New Tab 3. Navigate to any webpage 4. Error page displayed. 5. Turn ON wifi App is not crashing, but also Tab is not auto reloaded. It is working in a slightly different case: Steps: 1. Tap Menu --> New Tab 2. Turn OFF wifi. 3. Navigate to any webpage 4. Error page displayed. 5. Turn ON wifi Tab is auto reloaded fine and webpage loaded. gambard@ Please let me know if this needs to be filed as a new bug? Tested on iPhone7, iOS10.3 M59.0.3071.27 Link to video showing both the cases: https://drive.google.com/file/d/0B-xmXLQhjeKucjFHbWdlT3BnTWM/view
,
Apr 27 2017
Actually I don't know how auto-reload is supposed to work. We are currently investigating what is the expected behavior and if it should be presented to the user or not. No need to fill a bug, thanks for the testing!
,
Apr 27 2017
Thanks for the update. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Apr 19 2017