New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 712607 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

[Chrome Home] Sheet does not close after doodle click on NTP

Project Member Reported by mvanouwe...@chromium.org, Apr 18 2017

Issue description

The bottom sheet does not close after clicking the doodle on the Chrome Home NTP. It remains visible above the search results page, without a shadow on it. When sliding down the sheet, the shadow is suddenly shown, fading out.
 
The fading shadow issue is known, but I didn't realize the sheet wasn't closing when the Doodle was clicked. Thank you for the report.
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a80017ed38340c00d1d214a3a2445acf5a9ed05

commit 2a80017ed38340c00d1d214a3a2445acf5a9ed05
Author: twellington <twellington@chromium.org>
Date: Wed Apr 19 15:02:41 2017

[Home] Close the BottomSheet when a URL is loaded on the NTP

This ensures that a click on the doodle will close the BottomSheet.

BUG= 712607 

Review-Url: https://codereview.chromium.org/2829523002
Cr-Commit-Position: refs/heads/master@{#465604}

[modify] https://crrev.com/2a80017ed38340c00d1d214a3a2445acf5a9ed05/chrome/android/java/src/org/chromium/chrome/browser/ntp/ChromeHomeNewTabPageBase.java

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38ce623f9ffd74711a06046ff47d371e5ca5a48c

commit 38ce623f9ffd74711a06046ff47d371e5ca5a48c
Author: twellington <twellington@chromium.org>
Date: Wed Apr 19 20:12:26 2017

Revert of [Home] Close the BottomSheet when a URL is loaded on the NTP (patchset #1 id:1 of https://codereview.chromium.org/2829523002/ )

Reason for revert:
Broke Lollipop Tester

junit.framework.AssertionFailedError: Sheet should be at half height expected:<1> but was:<3>
	at org.chromium.chrome.browser.ntp.ChromeHomeNewTabPageTest.validateState(ChromeHomeNewTabPageTest.java:197)
	at org.chromium.chrome.browser.ntp.ChromeHomeNewTabPageTest.createNewTab(ChromeHomeNewTabPageTest.java:168)
	at org.chromium.chrome.browser.ntp.ChromeHomeNewTabPageTest.testCloseNTP_TwoTabs(ChromeHomeNewTabPageTest.java:92)
	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
	at org.chromium.chrome.test.ChromeActivityTestCaseBase.runTest(ChromeActivityTestCaseBase.java:758)
	at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1853)

Original issue's description:
> [Home] Close the BottomSheet when a URL is loaded on the NTP
>
> This ensures that a click on the doodle will close the BottomSheet.
>
> BUG= 712607 
>
> Review-Url: https://codereview.chromium.org/2829523002
> Cr-Commit-Position: refs/heads/master@{#465604}
> Committed: https://chromium.googlesource.com/chromium/src/+/2a80017ed38340c00d1d214a3a2445acf5a9ed05

TBR=mvanouwerkerk@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 712607 

Review-Url: https://codereview.chromium.org/2830743003
Cr-Commit-Position: refs/heads/master@{#465726}

[modify] https://crrev.com/38ce623f9ffd74711a06046ff47d371e5ca5a48c/chrome/android/java/src/org/chromium/chrome/browser/ntp/ChromeHomeNewTabPageBase.java

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e59ca5cb92b38cd1fbf209c728f3cb3487b63f0

commit 2e59ca5cb92b38cd1fbf209c728f3cb3487b63f0
Author: twellington <twellington@chromium.org>
Date: Thu Apr 20 14:51:52 2017

Reland [Home] Close the BottomSheet when a URL is loaded on the NTP

This ensures that a click on the doodle will close the BottomSheet.
This reverts commit 38ce623f9ffd74711a06046ff47d371e5ca5a48c.

Previously the ChromeHomeNewTabPageTest cases were failing because the
sheet state was set twice causing the state change observer to be
notified while the sheet was still SCROLLING and not at its final
resting place. This patch is the same as the original commit except
that it ChromeHomeNewTabPageBase does not set the sheet state to
PEEK if the URL being loaded is the NTP.

BUG= 712607 

Review-Url: https://codereview.chromium.org/2831773002
Cr-Commit-Position: refs/heads/master@{#466006}

[modify] https://crrev.com/2e59ca5cb92b38cd1fbf209c728f3cb3487b63f0/chrome/android/java/src/org/chromium/chrome/browser/ntp/ChromeHomeNewTabPageBase.java

Labels: Hotlist-Chrome-Home
Status: Fixed (was: Assigned)

Sign in to add a comment