New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 712606 link

Starred by 1 user
Status: Fixed
Owner:
█ zqzh...@chromium.org
Android MediaRouter only (left Chro...
Closed: Apr 2017
Cc:
█ avayvod@chromium.org
mlamouri@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocking:
issue 714676



Sign in to add a comment

Create AutoplayPolicy class to handle all autoplay logics

Project Member Reported by zqzh...@chromium.org, Apr 18 2017 
We should move the autoplay logic to a separate helper class.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12d76adf4bb340d8e430a18c3a664940157800f6

commit 12d76adf4bb340d8e430a18c3a664940157800f6
Author: zqzhang <zqzhang@chromium.org>
Date: Thu Apr 20 21:24:05 2017

[Blink>Media] Moving autoplay logic to AutoplayPolicy

This CL moves autoplay code from HTMLMediaElement to the
AutoplayPolicy class, which helps decoupling the autoplay logic
from HTMLMediaElement.

BUG= 712606 

Review-Url: https://codereview.chromium.org/2813303005
Cr-Commit-Position: refs/heads/master@{#466137}

[modify] https://crrev.com/12d76adf4bb340d8e430a18c3a664940157800f6/docs/media/autoplay.md
[modify] https://crrev.com/12d76adf4bb340d8e430a18c3a664940157800f6/third_party/WebKit/Source/core/html/BUILD.gn
[modify] https://crrev.com/12d76adf4bb340d8e430a18c3a664940157800f6/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/12d76adf4bb340d8e430a18c3a664940157800f6/third_party/WebKit/Source/core/html/HTMLMediaElement.h
[add] https://crrev.com/12d76adf4bb340d8e430a18c3a664940157800f6/third_party/WebKit/Source/core/html/media/AutoplayPolicy.cpp
[add] https://crrev.com/12d76adf4bb340d8e430a18c3a664940157800f6/third_party/WebKit/Source/core/html/media/AutoplayPolicy.h
[modify] https://crrev.com/12d76adf4bb340d8e430a18c3a664940157800f6/third_party/WebKit/Source/core/html/media/AutoplayUmaHelper.cpp
[modify] https://crrev.com/12d76adf4bb340d8e430a18c3a664940157800f6/third_party/WebKit/Source/core/html/media/AutoplayUmaHelper.h
[modify] https://crrev.com/12d76adf4bb340d8e430a18c3a664940157800f6/third_party/WebKit/Source/core/html/media/AutoplayUmaHelperTest.cpp

Comment 2 by zqzh...@chromium.org, Apr 20 2017

Status: Fixed (was: Started)

Comment 3 by mlamouri@chromium.org, Apr 24 2017

Blocking: 714676
►

Sign in to add a comment