New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 712585 link

Starred by 2 users
Status: Fixed
Owner:
ellyjo...@chromium.org
Closed: Dec 2017
Cc:
hwi@chromium.org
nyerramilli@chromium.org
tapted@chromium.org
█ msrchandra@chromium.org
bettes@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: 2017-11-10
OS: Linux , Windows , Mac
Pri: 2
Type: Bug
Launch-M-Target: 64-Beta

Blocking:
issue 605657



Sign in to add a comment

[Harmony] Remove chevron after the “Show Details” link in ’Add extension’ dialog

Reported by abom...@etouch.net, Apr 18 2017 
Chrome Version: 59.0.3071.9 (Official Build) 2ae1b9cb3ac16142bb504b4529323d14d0eb6f93-refs/branch-heads/3071@{#28}
OS:Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.1)

Pre-condition:Enable ‘secondary-ui-md’ flag

Test url: https://chrome.google.com/webstore/detail/social-blade/cfidkbgamfhdgmedldkagjopnbobdmdn?hl=en-GB

What steps will reproduce the problem?
1. Launch chrome and navigate to above link.
2. Click on ‘Add chrome’ button such that dialogs appears ,observe “Show Details” link

Actual: “Show Details” link is misplaced in ’Add extension’ dialog box.
Expected: “Show Details” link should be in proper.

This is regression issue, broken in ‘M 59’ and below is manual bisect :
Good build:59.0.3064.0
Bad build:59.0.3065.0

Comment 1 by sandeepkumars@chromium.org, Apr 18 2017

Owner: imch...@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:59.0.3064.0 (Revision:462305).
Bad build:59.0.3065.0 (Revision:462712).

You are probably looking for a change made after 462306 (known good), but no later than 462307 (first known bad).

CHANGE-LOG URL:
===============
https://chromium.googlesource.com/chromium/src/+/16f6f2938e2ac13dd9a20e4a643ac6e90c03d0c9

From the CL above, assigning the issue to the concern owner

imcheng: Could you please look into the issue, and help us in re assigning the issue to appropriate owner if it is not related your change. 

Review-Url: https://codereview.chromium.org/2805553002

Note: Able to reproduce issue on Mac 10.12.3 and Win 10 using latest Canary 60.0.3074.0

Comment 2 by imch...@chromium.org, Apr 18 2017

Owner: rdevlin....@chromium.org
Status: Untriaged (was: Assigned)
I don't think my change could have affected the add extensions dialog. Devlin, could you triage this?

Comment 3 by rdevlin....@chromium.org, Apr 18 2017

Owner: tapted@chromium.org
Status: Assigned (was: Untriaged)
Over to tapted@ for harmony triage, though I don't know whether harmony's ready for bugs filed against it.

Comment 4 by tapted@chromium.org, Apr 19 2017

Blocking: 605657
Labels: -Type-Bug-Regression Proj-HarmonyDialogs Type-Bug
Owner: ellyjo...@chromium.org
Summary: [Harmony] Remove chevron after to “Show Details” link in ’Add extension’ dialog (was: Regression: [Harmony] “Show Details” link is misplaced in ’Add extension’ dialog box.)
The vertical alignment of the chevron is off after r462676 which implemented line spacing in Harmony. The mocks in  Issue 605657  don't have a chevron, so we probably just want to remove it rather than align its baseline.

There may be a glitch for the horizontal alignment of 'Show details' too.

Assigning to elly since she has  Issue 605657  for now.

Comment 5 by tapted@chromium.org, Apr 19 2017

Summary: [Harmony] Remove chevron after the “Show Details” link in ’Add extension’ dialog (was: [Harmony] Remove chevron after to “Show Details” link in ’Add extension’ dialog)

Comment 6 by sandeepkumars@chromium.org, Apr 19 2017 

Tested this issue on Win 10 and Mac 10.12.4 using latest Canary 60.0.3074.0, and the issue is still reproducible.

Comment 7 by ellyjo...@chromium.org, Apr 24 2017

Status: Started (was: Assigned)
https://codereview.chromium.org/2837043003/

Comment 8 by ellyjo...@chromium.org, Apr 26 2017 

Non-Harmony screenshots attached.

before-show: pre-change, Show link
before-hide: pre-change, Hide link
after-show: post-change, Show link
after-hide: post-change, Hide link
before-show.png
12.4 KB View Download
before-hide.png
15.0 KB View Download
after-show.png
12.8 KB View Download
after-hide.png
14.0 KB View Download

Comment 9 by ellyjo...@chromium.org, Apr 26 2017 

Harmony screenshot without the arrow (the black line is a visual artifact, not part of the dialog).
harmony-show.png
14.8 KB View Download

Comment 10 by ellyjo...@chromium.org, Apr 26 2017

Cc: hwi@chromium.org
+hwi for UX

hwi@, is it okay to remove the arrow from the pre-Harmony version of this dialog as well? It is significantly simpler to do this way.

Comment 11 by ellyjo...@chromium.org, Apr 26 2017

Cc: bettes@chromium.org
+bettes also

Comment 12 by pkasting@chromium.org, Aug 8 2017

Labels: -Pri-1 Pri-2

Comment 13 by pkasting@chromium.org, Aug 9 2017

Labels: -M-59

Comment 14 by abdulsyed@google.com, Sep 5 2017

Labels: Launch-M-Target-64-Beta

Comment 15 by abdulsyed@google.com, Sep 5 2017

NextAction: 2017-11-10

Comment 16 by abdulsyed@chromium.org, Sep 20 2017 

Are there any updates on this bug?

Comment 17 by ellyjo...@chromium.org, Sep 22 2017 

The CL linked in #8 never got the UX signoff for removing the arrow in pre-Harmony that the code owner asked for. This bug needs UX attention or some other UX signoff for removing the arrow pre-Harmony.

Comment 18 by monor...@bugs.chromium.org, Nov 10 2017 

The NextAction date has arrived: 2017-11-10

Comment 19 by hwi@chromium.org, Nov 13 2017 

+bettes@ for C#17

Comment 20 by bsep@chromium.org, Dec 14 2017

Status: Fixed (was: Started)
I did this as part of  bug 605657 ; I didn't realize there was a separate bug for it.
►

Sign in to add a comment