Image capture: single-shot is not working if device is using camera2 backend
Reported by
infotoo...@gmail.com,
Apr 18 2017
|
|||||
Issue descriptionSteps to reproduce the problem: Call ImageCapture.setOptions with focusMode=single-shot on device using camera2 backend ,ex one plus 3 What is the expected behavior? It should trigger a camera focus operation What went wrong? Camera focus operation is not triggered. https://chromium.googlesource.com/chromium/src.git/+/master/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java#365 CONTROL_AF_TRIGGER_START will not trigger a focus operation if focus mode is CONTROL_AF_MODE_CONTINUOUS_PICTURE.It will only lock the focus to last focus https://developer.android.com/reference/android/hardware/camera2/CameraMetadata.html#CONTROL_AF_MODE_CONTINUOUS_PICTURE Btw, setOptions recreate the camera session, which is quite expensive process and might interfere focus operation Did this work before? No Does this work in other browsers? N/A Chrome version: 57.0.2987 Channel: stable OS Version: 7.1.1 Flash Version:
,
Jun 1 2017
Re. > Btw, setOptions recreate the camera session, which is quite expensive process and might interfere focus operation This has been addressed already, thanks ! Re the single-shot, yeah, it's a legit issue. Would need to trigger the AF routine correctly.
,
Jun 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e84e7da7c1503c959d7fc1f84aaa1c25d9edcc5 commit 1e84e7da7c1503c959d7fc1f84aaa1c25d9edcc5 Author: Miguel Casas-Sanchez <mcasas@chromium.org> Date: Thu Jun 22 03:21:53 2017 Image Capture Android: fix broken single-shot auto focus This CL moves the treatment of AndroidMeteringMode.SINGLE_SHOT out of configureCommonCaptureSettings() and into the preview-configuration specifics. To trigger a single-shot focus adjustment this CL triggers a single shot capture() on the Session (as opposed to the "normal" preview that uses setRepeatingRequest() and similar to the Flash-enabled auto-exposure calibration at the end of takePhoto() ). Note that the single-shot is triggered whenever either: - single-shot is explicitly configured by passing it to setPhotoOptions() - with the capture configured in SINGLE_SHOT, the user changes the |pointsOfInterest2D| Bug: 712568 Change-Id: Id23d037b67ad9cfd1ebc43e8f936b274897647f5 Reviewed-on: https://chromium-review.googlesource.com/530159 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#481424} [modify] https://crrev.com/1e84e7da7c1503c959d7fc1f84aaa1c25d9edcc5/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java
,
Jun 23 2017
infotoo.hk@gmail.com this should be Fixed with #3, can you please Verify? thanks
,
Jan 8 2018
Unfortunately, I am going to have to reopen this, because we had to revert the CL that fixed this. It depends on a preceding refactoring that turned out to trigger more severe issues when starting the video preview, see https://bugs.chromium.org/p/chromium/issues/detail?id=793859. Hopefully we can reland the refactoring and that CL as soon as we have found the root cause and have a fix for it.
,
Aug 1
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by candr...@chromium.org
, Apr 20 2017