New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 712565 link

Starred by 1 user
Status: Fixed
Owner:
█ chili@chromium.org
Last visit 22 days ago
Closed: Apr 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

unit_tests failing on chromium.android/Android N5X Swarm Builder

Project Member Reported by tobiasjs@chromium.org, Apr 18 2017 
unit_tests failing on chromium.android/Android N5X Swarm Builder

Builders failed on: 
- Android N5X Swarm Builder: 
  https://build.chromium.org/p/chromium.android/builders/Android%20N5X%20Swarm%20Builder

The test that's failing is BackgroundLoaderOfflinerTest.OnlySavesOnceOnMultipleLoads

because it now flakily returns SAVED_ON_LAST_RETRY instead of SAVED.

That enum was added recently in https://codereview.chromium.org/2818783002
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02aac2715c6e86bd7a4c81290df414e3269d7f31

commit 02aac2715c6e86bd7a4c81290df414e3269d7f31
Author: chili <chili@chromium.org>
Date: Tue Apr 18 20:34:15 2017

Fix for BackgroundLoaderOffliner::OnlySavesOnceOnMultipleLoads flake?

BUG= 712565 

Review-Url: https://codereview.chromium.org/2825823003
Cr-Commit-Position: refs/heads/master@{#465353}

[modify] https://crrev.com/02aac2715c6e86bd7a4c81290df414e3269d7f31/chrome/browser/android/offline_pages/background_loader_offliner.cc

Comment 2 by chili@chromium.org, Apr 19 2017

Status: Fixed (was: Available)
Closing the issue since my fix seemed to have worked
►

Sign in to add a comment