New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 712540 link

Starred by 1 user
Status: Fixed
Owner:
einbinder@chromium.org
Closed: Apr 2017
Cc:
nyerramilli@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
█ sureshkumari@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: [DevTools] Unable to close the 'Settings' page on hitting 'Esc' key.

Reported by dchau...@etouch.net, Apr 18 2017 
Chrome Version: 59.0.3071.9 (Official Build) (64-bit)2ae1b9cb3ac16142bb504b4529323d14d0eb6f93-refs/branch-heads/3071@{#28} 32/64-bit.
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.1).

What steps will reproduce the problem?
1. Launch chrome, open DevTools, press 'F1' key to open 'Settings' page.
2. Go to 'Blackboxing' section and click on 'Add pattern' button.
3. Hit 'Esc' key (Pattern section will close), again press 'Esc' key and observe.

'Settings' page doesn't close on hitting 'Esc' key.
'Settings' page should get closed on hitting 'Esc' key.

This is a regression issue, broken in M-58 series, below is manual regression range.

Good build: 58.0.2999.0
Bad build: 58.0.3000.0

Kindly review the attached screen-cast for reference.
Actual behavior.mp4
815 KB View Download
Expected behavior.mp4
639 KB View Download

Comment 1 by sureshkumari@chromium.org, Apr 18 2017

Cc: sureshkumari@chromium.org
Labels: hasbisect-per-revision
Owner: dgozman@chromium.org
Status: Assigned (was: Unconfirmed)
Manual Bisect:
-------------
Good build: 58.0.2999.0-Revision-447413
Bad build: 58.0.3001.0 -Revision-447896

Per revision bisect Tool Info:
-----------------------------
CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/09a6a441c91c5a52650c315cc915fe461e58cb33..ed1f2fac6209f8d2e0db3f7dcff38d1e69f5db26

Review-Url: https://codereview.chromium.org/2658383002
dgozman@ Kindly take a look and please help us to reassign this issue to a right owner if not with respect to this change.
Thanks.!

Comment 2 by dgozman@chromium.org, Apr 18 2017

Owner: einbinder@chromium.org
Joel, mind taking a look?
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45a2288ee7981e473f3b9848aae3d11bb7cfab2c

commit 45a2288ee7981e473f3b9848aae3d11bb7cfab2c
Author: einbinder <einbinder@chromium.org>
Date: Sat Apr 22 01:37:53 2017

DevTools: Don't lose focus when interacting with ListWidget

ListWidget often removes or hides the currently focused element, causing
focus to be lost.

BUG= 712540 

Review-Url: https://codereview.chromium.org/2829683003
Cr-Commit-Position: refs/heads/master@{#466520}

[modify] https://crrev.com/45a2288ee7981e473f3b9848aae3d11bb7cfab2c/third_party/WebKit/Source/devtools/front_end/ui/ListWidget.js

Comment 4 by einbinder@chromium.org, Apr 22 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment