New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 712539 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unnecessary space is seen in Report an Issue overlay.

Reported by ngu...@etouch.net, Apr 18 2017

Issue description

Chrome Version: 60.0.3074.0 (Official Build) 147bd1eedea8ce66f162faa43535d60137817d91-refs/heads/master@{#465085} (32/64-bit) 
OS: Windows (7,8,10), Linux (Ubuntu 14.04 LTS)

What steps will reproduce the problem?
1) Launch chrome, click on wrench menu, select 'Help' and then click on 'Report an Issue'.
2) Observe the area below 'Send' button on 'Report an Issue' overlay.

Unnecessary space is seen below Send button. 

No such space should be seen.

This is a Regression issue broken in M-60, will soon update other info
Manual bisect:
Good build: 60.0.3073.0
Bad build: 60.0.3074.0


 
report_Actual.jpg
164 KB View Download

Comment 1 by ngu...@etouch.net, Apr 18 2017

Labels: -OS-iOS OS-Mac
Note: Issue is seen on Mac OS (10.11.6, 10.12.1)
Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision
Owner: afakhry@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:60.0.3073.0 (Revision:464873).
Bad build:60.0.3074.0 (Revision:465085).

You are probably looking for a change made after 465056 (known good), but no later than 465057 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/ea81c77b5c2512e29f5b7fda56134778cac21a61..8a299993ec8d4a6a5c58dfa30dacf58a5bc8aa0d

From the CL above, assigning the issue to the concern owner

@afakhry: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url:https://codereview.chromium.org/2826563002
Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.3 and Able to reproduce in latest Canary #60.0.3074.0
Cc: xiy...@chromium.org
Status: Started (was: Assigned)
That's because the email section is hidden, so everything shifted upwards.
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1fbbd6d02b15123242c4782ca8830048d300e55

commit f1fbbd6d02b15123242c4782ca8830048d300e55
Author: afakhry <afakhry@chromium.org>
Date: Wed Apr 19 19:33:55 2017

Make sure feedback app footer buttons stick to the bottom

If item get removed from the content pane, the buttons should always
remain at the bottom.

BUG= 712539 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2833533002
Cr-Commit-Position: refs/heads/master@{#465708}

[modify] https://crrev.com/f1fbbd6d02b15123242c4782ca8830048d300e55/chrome/browser/resources/feedback/css/feedback.css

Status: Fixed (was: Started)
Labels: Merge-Request-59
Project Member

Comment 7 by sheriffbot@chromium.org, Apr 21 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 21 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f150018dcd6b6ccfec498f0e912f8dcee96437fd

commit f150018dcd6b6ccfec498f0e912f8dcee96437fd
Author: Ahmed Fakhry <afakhry@google.com>
Date: Fri Apr 21 00:34:16 2017

[Merge to M59] Make sure feedback app footer buttons stick to the bottom

If item get removed from the content pane, the buttons should always
remain at the bottom.

TBR=xiyuan@chromium.org
BUG= 712539 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2833533002
Cr-Commit-Position: refs/heads/master@{#465708}
(cherry picked from commit f1fbbd6d02b15123242c4782ca8830048d300e55)

Review-Url: https://codereview.chromium.org/2827343003 .
Cr-Commit-Position: refs/branch-heads/3071@{#109}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/f150018dcd6b6ccfec498f0e912f8dcee96437fd/chrome/browser/resources/feedback/css/feedback.css

Labels: TE-Verified-M59 TE-Verified-59.0.3071.25
Verified this issue on Windows-10, Mac 10.12.4 and Ubuntu 14.04 using chrome latest Dev #59.0.3071.25 by following steps mentioned in the original comment

No extra space is seen in the latest build. Please find the screen cast
Apr 25 2017 2-55 PM.webm
2.1 MB View Download

Sign in to add a comment