Issue metadata
Sign in to add a comment
|
Auto Download page action icon does not match Page Info |
||||||||||||||||||||||||
Issue descriptionChrome 60.0.3073.0 OSX 10.12.4 What steps will reproduce the problem? (1) Visit https://permission.site (2) Click "Auto download" What is the expected result? The page action icon matches Page Info (page-info.png). What happens instead? The icons are different (page-action.png). I got the Page Info icons from Max. dominickn@, could you triage?
,
Apr 18 2017
It looks to me like chrome/browser/ui/content_settings/content_setting_image_model.cc should set a different icon. I don't really have cycles available to look into this unfortunately.
,
Apr 18 2017
Looks like estade@ last touched these, in https://codereview.chromium.org/2721823002 estade@, do you know where the current icons are from?
,
Apr 18 2017
Although, for what it's work, I think it actually makes sense to align Page Info with the single-arrow icon, since that icon is not used more prominently (e.g. on mobile). maxwalker@, can you advise whether the icons should be the same, and which it should be?
,
Apr 18 2017
icons came from sgabriel@
,
Nov 6 2017
+Patti as FYI. maxwalker: can you comment on #4? This might be something we can fix easily as part of harmony Page info.
,
Nov 10 2017
,
Jan 18 2018
This was also fixed by r530031. Link for convenience: https://chromium-review.googlesource.com/c/chromium/src/+/778640
,
Jan 18 2018
awesome!! |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by lgar...@chromium.org
, Apr 18 2017