New issue
Advanced search Search tips

Issue 712507 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 712502



Sign in to add a comment

Get rid of "global secrets" in AuthDB

Project Member Reported by vadimsh@chromium.org, Apr 18 2017

Issue description

This feature was never used, it just frighten and confuse people.
 
Project Member

Comment 2 by bugdroid1@chromium.org, May 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/48827429b285dc91ba2fe1bc3dcb2ad55b76f972

commit 48827429b285dc91ba2fe1bc3dcb2ad55b76f972
Author: vadimsh <vadimsh@chromium.org>
Date: Mon May 08 21:10:09 2017

auth: Stop mentioning 'global' secrets in API.

There's no global secrets anymore, they are always local.

R=iannucci@chromium.org
BUG= 712507 

Review-Url: https://codereview.chromium.org/2854853005

[modify] https://crrev.com/48827429b285dc91ba2fe1bc3dcb2ad55b76f972/appengine/auth_service/handlers_frontend.py
[modify] https://crrev.com/48827429b285dc91ba2fe1bc3dcb2ad55b76f972/appengine/components/components/auth/api.py
[modify] https://crrev.com/48827429b285dc91ba2fe1bc3dcb2ad55b76f972/appengine/components/components/auth/api_test.py
[modify] https://crrev.com/48827429b285dc91ba2fe1bc3dcb2ad55b76f972/appengine/components/components/auth/handler.py
[modify] https://crrev.com/48827429b285dc91ba2fe1bc3dcb2ad55b76f972/appengine/components/components/auth/model.py
[modify] https://crrev.com/48827429b285dc91ba2fe1bc3dcb2ad55b76f972/appengine/components/components/auth/model_test.py
[modify] https://crrev.com/48827429b285dc91ba2fe1bc3dcb2ad55b76f972/appengine/components/components/auth/replication_test.py
[modify] https://crrev.com/48827429b285dc91ba2fe1bc3dcb2ad55b76f972/appengine/components/components/auth/tokens.py
[modify] https://crrev.com/48827429b285dc91ba2fe1bc3dcb2ad55b76f972/appengine/components/components/auth/tokens_test.py
[modify] https://crrev.com/48827429b285dc91ba2fe1bc3dcb2ad55b76f972/appengine/isolate/handlers_endpoints_v1.py
[modify] https://crrev.com/48827429b285dc91ba2fe1bc3dcb2ad55b76f972/appengine/swarming/server/bot_code.py

Project Member

Comment 3 by bugdroid1@chromium.org, May 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/48827429b285dc91ba2fe1bc3dcb2ad55b76f972

commit 48827429b285dc91ba2fe1bc3dcb2ad55b76f972
Author: vadimsh <vadimsh@chromium.org>
Date: Mon May 08 21:10:09 2017

auth: Stop mentioning 'global' secrets in API.

There's no global secrets anymore, they are always local.

R=iannucci@chromium.org
BUG= 712507 

Review-Url: https://codereview.chromium.org/2854853005

[modify] https://crrev.com/48827429b285dc91ba2fe1bc3dcb2ad55b76f972/appengine/auth_service/handlers_frontend.py
[modify] https://crrev.com/48827429b285dc91ba2fe1bc3dcb2ad55b76f972/appengine/components/components/auth/api.py
[modify] https://crrev.com/48827429b285dc91ba2fe1bc3dcb2ad55b76f972/appengine/components/components/auth/api_test.py
[modify] https://crrev.com/48827429b285dc91ba2fe1bc3dcb2ad55b76f972/appengine/components/components/auth/handler.py
[modify] https://crrev.com/48827429b285dc91ba2fe1bc3dcb2ad55b76f972/appengine/components/components/auth/model.py
[modify] https://crrev.com/48827429b285dc91ba2fe1bc3dcb2ad55b76f972/appengine/components/components/auth/model_test.py
[modify] https://crrev.com/48827429b285dc91ba2fe1bc3dcb2ad55b76f972/appengine/components/components/auth/replication_test.py
[modify] https://crrev.com/48827429b285dc91ba2fe1bc3dcb2ad55b76f972/appengine/components/components/auth/tokens.py
[modify] https://crrev.com/48827429b285dc91ba2fe1bc3dcb2ad55b76f972/appengine/components/components/auth/tokens_test.py
[modify] https://crrev.com/48827429b285dc91ba2fe1bc3dcb2ad55b76f972/appengine/isolate/handlers_endpoints_v1.py
[modify] https://crrev.com/48827429b285dc91ba2fe1bc3dcb2ad55b76f972/appengine/swarming/server/bot_code.py

Components: Infra>Platform
Status: Fixed (was: Assigned)

Sign in to add a comment