histograms.xml should have OBSOLETE_ entries for removed UseCounter items. |
|||
Issue descriptionIn general we should not remove anything from historgrams.xml [1], and jwd@ suggested to add OBSOLETE_ to an obsolete item [2]. We should * Add OBSOLETE_ to items which we already removed from UseCounter.h * Automate it by update_use_counter_feature_enum.py or * Add OBSOLETE_ to UseCounter.h [1] https://chromium.googlesource.com/chromium/src/+/50101199bf7650dc70c0c0e03e1981d4f0ee7f73/tools/metrics/histograms/README.md [2] https://codereview.chromium.org/2261393002/
,
Apr 18 2017
> What would happen if we just remove entries from histograms.xml? In general, it would increase a risk to reuse numbers for removed entries. However, the risk would be very small for UseCounter because we usually update histograms.xml by a tool. When we stop counting a feature, * If we do nothing for histograms.xml, uma.googleplex.com and chromestatus.com can't know that the feature was not counted. they'll show invalid data. * If we remove an item from histograms.xml, there is a small risk to reuse a number. * If we prepend OBSOLETE_ to the item in histograms.xml, the risk is smaller, and uma.googleplex.com and chromestatus.com can exclude such item.
,
Apr 18 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 19 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by foolip@chromium.org
, Apr 18 2017