New issue
Advanced search Search tips

Issue 712472 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

DevTools: replace box appears when tabbing from find input in console/sources

Project Member Reported by l...@chromium.org, Apr 18 2017

Issue description

Chrome Version: (copy from chrome://version)
OS: (e.g. Win7, OSX 10.9.5, etc...)

What steps will reproduce the problem?
(1) Open the find box in console/sources with Ctrl-F
(2) Press 'Tab' to jump focus out of the find input field

What is the expected result?
No replace input should appear

What happens instead?
Focus jumps to the replace input!

I haven't done a bisect, but I'm suspicious of this CL
https://codereview.chromium.org/2734043002

 
findReplaceOhno.png
31.4 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5f56eaf9aa0338be5de51380df8cf90814e2444

commit f5f56eaf9aa0338be5de51380df8cf90814e2444
Author: luoe <luoe@chromium.org>
Date: Thu Apr 20 01:47:26 2017

DevTools: hide the replace input when it replace is disabled

BUG= 712472 

Review-Url: https://codereview.chromium.org/2829433002
Cr-Commit-Position: refs/heads/master@{#465854}

[modify] https://crrev.com/f5f56eaf9aa0338be5de51380df8cf90814e2444/third_party/WebKit/Source/devtools/front_end/ui/SearchableView.js

Comment 2 by l...@chromium.org, Apr 20 2017

Status: Fixed (was: Assigned)

Sign in to add a comment