New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 712459 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-use-after-free in blink::EventHandler::SelectAutoCursor

Project Member Reported by ClusterFuzz, Apr 17 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6044738269741056

Fuzzer: miaubiz_svg_fuzzer
Job Type: windows_asan_chrome_no_sandbox
Platform Id: windows

Crash Type: Heap-use-after-free READ 4
Crash Address: 0x083217e0
Crash State:
  blink::EventHandler::selectAutoCursor
  blink::EventHandler::selectCursor
  blink::EventHandler::handleMouseMoveOrLeaveEvent
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome_no_sandbox&range=450347:450395

Reproducer Testcase: https://clusterfuzz.com/download/AMIfv95HWJoOerZOzUXiITqMJz-n_XUhLE3oN_YHhi-cQ46ADA9tJ-hfq5WcIJfIZ2dO9OOgd45H9Bk9DNn53dSug4IZFnmHWBHqFkuGYvb8fwA0HkXibqI0s24zyW98Wo5miGRMC3Ve8AM167M95dv3GXAwDaQXjCh4n2brmTC-qe8TBEq1MtQgNpPVPgxObEzwBRprWhkf0hw_BMKVIdDp1DlooYIsbFahpgRb8hFeli_oWfdnnJkD0MaG7g57QE0MApS_TGaXheg_9LdFs8he3ERUCf_Qhh7eH_KqcqdveNoxh8etEsIJe8swcKq-yThmQbiGgMd8KrCJt2bfZvISZKeX8bFD02wiUs40FQkxB1VjZ65JwK4?testcase_id=6044738269741056


Additional requirements: Requires Gestures

Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 

Comment 1 by est...@chromium.org, Apr 18 2017

Components: Internals>Input
Owner: yosin@chromium.org
Status: Assigned (was: Untriaged)
yosin, could you please take a look? Maybe possibly related to d892f959 (it's in the regression range)?
Project Member

Comment 2 by sheriffbot@chromium.org, Apr 18 2017

Labels: M-58
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 18 2017

Labels: ReleaseBlock-Stable
Project Member

Comment 4 by sheriffbot@chromium.org, Apr 18 2017

Labels: Pri-1
Project Member

Comment 5 by sheriffbot@chromium.org, Apr 19 2017

Labels: M-58

Comment 6 by gov...@chromium.org, Apr 19 2017

Cc: awhalley@chromium.org

Comment 7 by awhalley@google.com, Apr 19 2017

Labels: -M-58 M-59
Too late for M58, pushing to 59.

Comment 8 by yosin@chromium.org, Apr 27 2017

Labels: -M-59

Comment 9 by yosin@chromium.org, Apr 27 2017

Labels: Pri-2
Owner: ----
Status: Available (was: Assigned)
Lower to Pri-2, since this issue caused by unusual HTML.
Project Member

Comment 10 by sheriffbot@chromium.org, Apr 27 2017

Labels: M-58
Project Member

Comment 11 by sheriffbot@chromium.org, Apr 27 2017

Labels: -Pri-2 Pri-1
+awhalley@, will this be a blocker for M58 Stable AU ramp up or respin?
Labels: -M-58 M-59
Nope - moving to 59.
Cc: bokan@chromium.org dtapu...@chromium.org
Components: Blink>Input
Labels: OS-Android OS-Chrome OS-Linux OS-Mac
Owner: lanwei@chromium.org
Status: Assigned (was: Available)
Summary: Heap-use-after-free in blink::EventHandler::SelectAutoCursor (was: Heap-use-after-free in blink::EventHandler::selectAutoCursor)
lanwei, any chance you could take a look? +some input/events OWNERS too.
Owner: dtapu...@chromium.org
Cc: yosin@chromium.org
This is caused by https://chromium.googlesource.com/chromium/src/+/d892f9592860691ae9a782c12260c94ed6bd1a63%5E%21/#F30

who added a layout inside the method EventHandler is using.
Cc: jbroman@chromium.org
Project Member

Comment 19 by bugdroid1@chromium.org, Apr 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d6b6c40b933564260a0a70567b90ac30656222a

commit 9d6b6c40b933564260a0a70567b90ac30656222a
Author: dtapuska <dtapuska@chromium.org>
Date: Fri Apr 28 17:34:06 2017

Cleanup determining ibeam for node.

Change
https://chromium.googlesource.com/chromium/src/+/d892f9592860691ae9a782c12260c94ed6bd1a63%5E%21/#F30

caused the layout object to possibly be invalidated. Collapse the code
so that LayoutObject is correclty scoped so we don't run this risk.

BUG= 712459 

Review-Url: https://codereview.chromium.org/2849883002
Cr-Commit-Position: refs/heads/master@{#468045}

[modify] https://crrev.com/9d6b6c40b933564260a0a70567b90ac30656222a/third_party/WebKit/Source/core/input/EventHandler.cpp

Project Member

Comment 20 by ClusterFuzz, Apr 28 2017

Detailed report: https://clusterfuzz.com/testcase?key=5494570986242048

Job Type: linux_asan_chrome_mp
Crash Type: 
Crash Address: 
Crash State:
  
Sanitizer: address (ASAN)

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5494570986242048


Additional requirements: Requires Gestures

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
Project Member

Comment 21 by ClusterFuzz, Apr 29 2017

ClusterFuzz has detected this issue as fixed in range 468030:468057.

Detailed report: https://clusterfuzz.com/testcase?key=6044738269741056

Fuzzer: miaubiz_svg_fuzzer
Job Type: windows_asan_chrome_no_sandbox
Platform Id: windows

Crash Type: Heap-use-after-free READ 4
Crash Address: 0x083217e0
Crash State:
  blink::EventHandler::selectAutoCursor
  blink::EventHandler::selectCursor
  blink::EventHandler::handleMouseMoveOrLeaveEvent
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome_no_sandbox&range=450347:450395
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_chrome_no_sandbox&range=468030:468057

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6044738269741056


Additional requirements: Requires Gestures

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 22 by ClusterFuzz, Apr 29 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6044738269741056 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 23 by sheriffbot@chromium.org, Apr 29 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: Merge-Request-59
Project Member

Comment 25 by sheriffbot@chromium.org, Apr 29 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 26 by bugdroid1@chromium.org, May 1 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1dcdc127c1463d62c3e57a260e5a03869eab6024

commit 1dcdc127c1463d62c3e57a260e5a03869eab6024
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Mon May 01 13:51:23 2017

Cleanup determining ibeam for node.

Change
https://chromium.googlesource.com/chromium/src/+/d892f9592860691ae9a782c12260c94ed6bd1a63%5E%21/#F30

caused the layout object to possibly be invalidated. Collapse the code
so that LayoutObject is correclty scoped so we don't run this risk.

BUG= 712459 

Review-Url: https://codereview.chromium.org/2849883002
Cr-Commit-Position: refs/heads/master@{#468045}
(cherry picked from commit 9d6b6c40b933564260a0a70567b90ac30656222a)

Review-Url: https://codereview.chromium.org/2856553002 .
Cr-Commit-Position: refs/branch-heads/3071@{#318}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/1dcdc127c1463d62c3e57a260e5a03869eab6024/third_party/WebKit/Source/core/input/EventHandler.cpp

Labels: -Hotlist-Merge-Approved -ReleaseBlock-Stable
Labels: -reward-topanel reward-unpaid reward-1500
The VRP panel decided to award $1,000 for this bug, and of course $500 for the clusterfuzz bonus.
Labels: -reward-unpaid reward-inprocess
Project Member

Comment 31 by sheriffbot@chromium.org, Aug 5 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment