New issue
Advanced search Search tips

Issue 712453 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 706927
Owner: ----
Closed: Apr 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

96.6% regression in smoothness.sync_scroll.key_mobile_sites_smooth at 460171:460215

Project Member Reported by benhenry@google.com, Apr 17 2017

Issue description

bisect coming.
 

Comment 1 by benhenry@google.com, Apr 17 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=712453

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDggtj6mAsM


Bot(s) for this bug's original alert(s):

android-nexus5
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Apr 18 2017

Mergedinto: 706927
Status: Duplicate (was: Untriaged)

=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : skobes
  Commit : 56451775d90238d9def5e9663771de8d0ca7ef6f
  Date   : Tue Mar 28 18:46:38 2017
  Subject: Feed ScrollableArea::showOverlayScrollbars into ScrollbarAnimationController.

Bisect Details
  Configuration: android_nexus5_perf_bisect
  Benchmark    : smoothness.sync_scroll.key_mobile_sites_smooth
  Metric       : first_gesture_scroll_update_latency/http___digg.com
  Change       : 103.30% | 12.4098333333 -> 25.229

Revision             Result                  N
chromium@460170      12.4098 +- 1.47403      6      good
chromium@460176      14.5507 +- 11.2191      6      good
chromium@460177      20.2667 +- 68.1609      9      good
chromium@460178      29.1977 +- 33.7465      9      bad       <--
chromium@460179      25.4338 +- 1.48311      6      bad
chromium@460182      25.3502 +- 2.4499       6      bad
chromium@460193      25.5517 +- 2.63175      6      bad
chromium@460215      25.229 +- 2.2379        6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http...digg.com smoothness.sync_scroll.key_mobile_sites_smooth

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8982022305094254256

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5021722341801984


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a4d4531daca4b9a1f6dc1224bcb7134dc053ff4

commit 8a4d4531daca4b9a1f6dc1224bcb7134dc053ff4
Author: skobes <skobes@chromium.org>
Date: Mon Apr 24 19:19:10 2017

Temporarily ignore ScrollbarAnimationController::DidRequestShowFromMainThread.

BUG= 706927 , 712453 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2834703004
Cr-Commit-Position: refs/heads/master@{#466712}

[modify] https://crrev.com/8a4d4531daca4b9a1f6dc1224bcb7134dc053ff4/cc/input/scrollbar_animation_controller.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 24 2017

Labels: merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dddc56692b829eb3d12e23d47e82549381557d06

commit dddc56692b829eb3d12e23d47e82549381557d06
Author: Steve Kobes <skobes@chromium.org>
Date: Mon Apr 24 23:51:54 2017

Temporarily ignore ScrollbarAnimationController::DidRequestShowFromMainThread.

BUG= 706927 , 712453 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2834703004
Cr-Commit-Position: refs/heads/master@{#466712}
(cherry picked from commit 8a4d4531daca4b9a1f6dc1224bcb7134dc053ff4)

Review-Url: https://codereview.chromium.org/2836243002 .
Cr-Commit-Position: refs/branch-heads/3071@{#184}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/dddc56692b829eb3d12e23d47e82549381557d06/cc/input/scrollbar_animation_controller.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66aacfa671360982f234c0fbd3b186efe21ee763

commit 66aacfa671360982f234c0fbd3b186efe21ee763
Author: skobes <skobes@chromium.org>
Date: Wed Apr 26 23:40:39 2017

Re-enable ScrollbarAnimationController::DidRequestShowFromMainThread.

Disabling it didn't fix  http://crbug.com/706927 , but caused a new regression in
 http://crbug.com/715279 , while  http://crbug.com/712453  recovered for some other
reason.

BUG= 606395 ,  706927 ,  712453 ,  715279 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2834393003
Cr-Commit-Position: refs/heads/master@{#467513}

[modify] https://crrev.com/66aacfa671360982f234c0fbd3b186efe21ee763/cc/input/scrollbar_animation_controller.cc

Sign in to add a comment