New issue
Advanced search Search tips

[Site settings] Blocking bug for enabling Site Settings Details and All Sites

Project Member Reported by dschuyler@chromium.org, Apr 17 2017

Issue description

The site settings portion of Content settings was postponed until after MD settings shipped (which is happening in m59).
 
Blockedon: 706320
Blockedon: 606304
Blockedon: 534599
Blocking: 425627
Blockedon: 702117
Blockedon: 626619
Blockedon: 632618

Comment 8 by dbeam@chromium.org, Apr 17 2017

Labels: Hotlist-MD-Settings-Privacy-SiteSettings

Comment 9 by dbeam@chromium.org, Apr 17 2017

Cc: benwells@chromium.org patricia...@chromium.org

Comment 10 by dbeam@chromium.org, Apr 17 2017

Cc: emilyschechter@chromium.org
Blockedon: 672415
Blockedon: 661884
Blockedon: 658645
Blockedon: 653510
Blockedon: 653485
Blockedon: 651657
Blockedon: 653395
Blockedon: 647399
Blockedon: 656758
Blockedon: 658503
Blockedon: 713918
Blockedon: 716485
Blocking: -425627
Blockedon: 715496
Blockedon: 717468
Blockedon: 718313
Blockedon: 720328
Blockedon: 720294
Owner: benwells@chromium.org
Ben does it make sense for you or a member of your team to own this bug?
(Feel free to assign it back to me if not).
Sure, leave it with me.
Project Member

Comment 31 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa112ee5b220b30022bc27d68f3eeed618e9f154

commit fa112ee5b220b30022bc27d68f3eeed618e9f154
Author: dschuyler <dschuyler@chromium.org>
Date: Fri May 19 19:40:16 2017

[MD settings] separate all-sites from site-list

This CL moves the all-sites portion of site settings out of the site
list code. At one point the lists were more similar, I believe. It
became convoluted with special cases for all-sites and this CL simplifies
that.

BUG=712446
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2846723002
Cr-Commit-Position: refs/heads/master@{#473283}

[modify] https://crrev.com/fa112ee5b220b30022bc27d68f3eeed618e9f154/chrome/browser/resources/settings/site_settings/all_sites.html
[modify] https://crrev.com/fa112ee5b220b30022bc27d68f3eeed618e9f154/chrome/browser/resources/settings/site_settings/all_sites.js
[modify] https://crrev.com/fa112ee5b220b30022bc27d68f3eeed618e9f154/chrome/browser/resources/settings/site_settings/compiled_resources2.gyp
[modify] https://crrev.com/fa112ee5b220b30022bc27d68f3eeed618e9f154/chrome/browser/resources/settings/site_settings/site_list.html
[modify] https://crrev.com/fa112ee5b220b30022bc27d68f3eeed618e9f154/chrome/browser/resources/settings/site_settings/site_list.js
[add] https://crrev.com/fa112ee5b220b30022bc27d68f3eeed618e9f154/chrome/test/data/webui/settings/all_sites_tests.js
[modify] https://crrev.com/fa112ee5b220b30022bc27d68f3eeed618e9f154/chrome/test/data/webui/settings/cr_settings_browsertest.js
[modify] https://crrev.com/fa112ee5b220b30022bc27d68f3eeed618e9f154/chrome/test/data/webui/settings/site_list_tests.js

Blockedon: -606304
Blockedon: 726251
Blockedon: 705929
Cc: dominickn@chromium.org
Summary: [Site settings] Blocking bug for enabling Site Settings Details and All Sites (was: [Site settings] Blocking bug for enabling Site Settings Details and All)
Components: -UI>Settings UI>Browser>SiteSettings

Sign in to add a comment