Milo component has more bugs than desired which may indicate that current test coverage is insufficient. Increase test coverage to 80% in each Milo go package Context: LUCI Milestone Planning
Current test coverage by package: appengine/buildbot: 52% appengine/buildbucket: 41% appengine/common: 36% appengine/frontend: 41% appengine/swarming: 63% appengine/buildinfo: 0% Packages not in critical paths: appengine/logdog: 0% appengine/logs: 0%
Assigned to current milestone/sprint.
The following revision refers to this bug: https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/23968256fadb58591bf2e8d1fce49eab04b721bb commit 23968256fadb58591bf2e8d1fce49eab04b721bb Author: hinoka <hinoka@google.com> Date: Fri May 26 23:45:37 2017 Milo: Increase test coverage for appengine/buildbot Adds new tests and slight refactoring including: * Move most of the html test data out of the buildbot module into the frontend module. Because that code is only executed by the frontend test code, it makes more sense to put it there. The intention is to do the same with the other modules. * Because of the above, make the build implementation public. * Add new test cases and test files. This yields 81.1% test coverage for the buildbot module. BUG= 712431 Review-Url: https://codereview.chromium.org/2856273004 [modify] https://crrev.com/23968256fadb58591bf2e8d1fce49eab04b721bb/milo/appengine/buildbot/build.go [modify] https://crrev.com/23968256fadb58591bf2e8d1fce49eab04b721bb/milo/appengine/buildbot/build_test.go [modify] https://crrev.com/23968256fadb58591bf2e8d1fce49eab04b721bb/milo/appengine/buildbot/builder.go [add] https://crrev.com/23968256fadb58591bf2e8d1fce49eab04b721bb/milo/appengine/buildbot/builder_test.go [modify] https://crrev.com/23968256fadb58591bf2e8d1fce49eab04b721bb/milo/appengine/buildbot/buildinfo.go [modify] https://crrev.com/23968256fadb58591bf2e8d1fce49eab04b721bb/milo/appengine/buildbot/buildinfo_test.go [add] https://crrev.com/23968256fadb58591bf2e8d1fce49eab04b721bb/milo/appengine/buildbot/console_test.go [add] https://crrev.com/23968256fadb58591bf2e8d1fce49eab04b721bb/milo/appengine/buildbot/expectations/chromium_presubmit.426944.build.json [modify] https://crrev.com/23968256fadb58591bf2e8d1fce49eab04b721bb/milo/appengine/buildbot/grpc_test.go [modify] https://crrev.com/23968256fadb58591bf2e8d1fce49eab04b721bb/milo/appengine/buildbot/html.go [modify] https://crrev.com/23968256fadb58591bf2e8d1fce49eab04b721bb/milo/appengine/buildbot/html_data.go [add] https://crrev.com/23968256fadb58591bf2e8d1fce49eab04b721bb/milo/appengine/buildbot/html_test.go [add] https://crrev.com/23968256fadb58591bf2e8d1fce49eab04b721bb/milo/appengine/buildbot/master_test.go [modify] https://crrev.com/23968256fadb58591bf2e8d1fce49eab04b721bb/milo/appengine/buildbot/pubsub_test.go [add] https://crrev.com/23968256fadb58591bf2e8d1fce49eab04b721bb/milo/appengine/buildbot/testdata/chromium_presubmit.426944.json [modify] https://crrev.com/23968256fadb58591bf2e8d1fce49eab04b721bb/milo/appengine/common/middleware.go [add] https://crrev.com/23968256fadb58591bf2e8d1fce49eab04b721bb/milo/appengine/frontend/buildbot_data.go [add] https://crrev.com/23968256fadb58591bf2e8d1fce49eab04b721bb/milo/appengine/frontend/expectations/buildbot.build-Debug_page-_chromium_presubmit_426944.html [modify] https://crrev.com/23968256fadb58591bf2e8d1fce49eab04b721bb/milo/appengine/frontend/main_test.go
The following revision refers to this bug: https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/f5757f6f5ad535a7c6648531c06c5b5955ccbb39 commit f5757f6f5ad535a7c6648531c06c5b5955ccbb39 Author: hinoka <hinoka@google.com> Date: Wed May 31 21:35:09 2017 Milo: Fix deployment https://codereview.chromium.org/2856273004 broke deployment for Milo due to the difference in directory structure between the test environment and the prod environment. This makes template path something that the module that calls the middleware has to pass in, to allow for different modules to use the template bundle. BUG= 712431 Review-Url: https://codereview.chromium.org/2918563004 [modify] https://crrev.com/f5757f6f5ad535a7c6648531c06c5b5955ccbb39/milo/appengine/buildbot/html_test.go [modify] https://crrev.com/f5757f6f5ad535a7c6648531c06c5b5955ccbb39/milo/appengine/common/middleware.go [modify] https://crrev.com/f5757f6f5ad535a7c6648531c06c5b5955ccbb39/milo/appengine/frontend/main.go [modify] https://crrev.com/f5757f6f5ad535a7c6648531c06c5b5955ccbb39/milo/appengine/frontend/main_test.go
Comment 1 by efoo@chromium.org
, Apr 27 2017Labels: -Pri-3 REQBY-LUCI-M3-ClosedBeta LUCI-M1-Dev1 Pri-1