Issue metadata
Sign in to add a comment
|
Add telemetry benchmarks for accessibility |
||||||||||||||||||||||
Issue descriptionWe should have some telemetry benchmarks that allow us to track the performance of Chrome accessibility support. See https://catapult.gsrc.io/telemetry The measurement should probably just be the amount of time spent in accessibility code, on the browser and/or renderer side. Some possible story sets: * Loading pages (existing page cyclers could work) * Typing or deleting text into an input, textarea, or contenteditable * Resizing the page * Scrolling * Firing live region changes
,
Sep 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9107dc751f45d9ee45effe612c78e47df2ee82d6 commit 9107dc751f45d9ee45effe612c78e47df2ee82d6 Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org> Date: Tue Sep 26 07:12:30 2017 Roll src/third_party/catapult/ ae4cc909a..030de5515 (1 commit) https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/ae4cc909a3bb..030de5515608 $ git log ae4cc909a..030de5515 --date=short --no-merges --format='%ad %ae %s' 2017-09-25 dmazzoni Add support for Tab key, needed by an accessibility story. Created with: roll-dep src/third_party/catapult BUG= 712417 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Id70fefec2fe404d9c3243f42972af5f579027d18 Reviewed-on: https://chromium-review.googlesource.com/683816 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#504297} [modify] https://crrev.com/9107dc751f45d9ee45effe612c78e47df2ee82d6/DEPS
,
Sep 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a5edee6703dcbcdad0a19ef19a4636641c9af7b9 commit a5edee6703dcbcdad0a19ef19a4636641c9af7b9 Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Tue Sep 26 20:45:40 2017 Add accessibility coverage to system_health benchmark. Adds new stories that exercise things that sometimes cause performance problems for accessibility: live regions, large data tables, scrolling large complex sites, and typing in a contenteditable, and expands the system_health benchmark to track accessibility metrics. Bug: 712417 Change-Id: I8384083146650b3fae35ea223892053a7e0c0be4 Reviewed-on: https://chromium-review.googlesource.com/663208 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#504475} [modify] https://crrev.com/a5edee6703dcbcdad0a19ef19a4636641c9af7b9/tools/perf/benchmarks/system_health.py [modify] https://crrev.com/a5edee6703dcbcdad0a19ef19a4636641c9af7b9/tools/perf/page_sets/data/system_health_desktop.json [add] https://crrev.com/a5edee6703dcbcdad0a19ef19a4636641c9af7b9/tools/perf/page_sets/data/system_health_desktop_059.wprgo.sha1 [add] https://crrev.com/a5edee6703dcbcdad0a19ef19a4636641c9af7b9/tools/perf/page_sets/system_health/accessibility_stories.py [modify] https://crrev.com/a5edee6703dcbcdad0a19ef19a4636641c9af7b9/tools/perf/page_sets/system_health/story_tags.py [modify] https://crrev.com/a5edee6703dcbcdad0a19ef19a4636641c9af7b9/tools/perf/page_sets/system_health/system_health_story.py
,
Sep 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9edd0dee2801e92d01cc480da7607fbaf8e0f98a commit 9edd0dee2801e92d01cc480da7607fbaf8e0f98a Author: vitaliii <vitaliii@chromium.org> Date: Wed Sep 27 09:32:26 2017 Revert "Add accessibility coverage to system_health benchmark." This reverts commit a5edee6703dcbcdad0a19ef19a4636641c9af7b9. Reason for revert: browse_accessibility:tools:gmail_compose is flaky. I would happily disable just this test, but I don't know how. I tried, but I do not know which story set it belongs to. Please update the sheriff guide https://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-How-do-I-disable-a-flaky-test- with a description how to disable your tests. Original change's description: > Add accessibility coverage to system_health benchmark. > > Adds new stories that exercise things that sometimes cause performance > problems for accessibility: live regions, large data tables, scrolling > large complex sites, and typing in a contenteditable, and expands the > system_health benchmark to track accessibility metrics. > > Bug: 712417 > Change-Id: I8384083146650b3fae35ea223892053a7e0c0be4 > Reviewed-on: https://chromium-review.googlesource.com/663208 > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Ned Nguyen <nednguyen@google.com> > Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> > Cr-Commit-Position: refs/heads/master@{#504475} TBR=dmazzoni@chromium.org,perezju@chromium.org,nednguyen@google.com Change-Id: Ib3357cca3154eee6925e3a12eacc3dbb0b46526f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 712417 , 769217 Reviewed-on: https://chromium-review.googlesource.com/686454 Reviewed-by: vitaliii <vitaliii@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#504609} [modify] https://crrev.com/9edd0dee2801e92d01cc480da7607fbaf8e0f98a/tools/perf/benchmarks/system_health.py [modify] https://crrev.com/9edd0dee2801e92d01cc480da7607fbaf8e0f98a/tools/perf/page_sets/data/system_health_desktop.json [delete] https://crrev.com/051a3c9b3603f18c80aa98c7411ec3f6cc4e6674/tools/perf/page_sets/data/system_health_desktop_059.wprgo.sha1 [delete] https://crrev.com/051a3c9b3603f18c80aa98c7411ec3f6cc4e6674/tools/perf/page_sets/system_health/accessibility_stories.py [modify] https://crrev.com/9edd0dee2801e92d01cc480da7607fbaf8e0f98a/tools/perf/page_sets/system_health/story_tags.py [modify] https://crrev.com/9edd0dee2801e92d01cc480da7607fbaf8e0f98a/tools/perf/page_sets/system_health/system_health_story.py
,
Sep 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b3e1a0ac9efb9ad51efa77786881bae5ebf64d7d commit b3e1a0ac9efb9ad51efa77786881bae5ebf64d7d Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Wed Sep 27 22:33:47 2017 Re-land: Add accessibility coverage to system_health benchmark. It looks like the test was just timing out. Shortened the text used by AccessibilityGmailComposeStory significantly. Locally the test went from taking 110s to 54s. Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/663208 Reverted: https://chromium-review.googlesource.com/686454 Adds new stories that exercise things that sometimes cause performance problems for accessibility: live regions, large data tables, scrolling large complex sites, and typing in a contenteditable, and expands the system_health benchmark to track accessibility metrics. Bug: 712417 Change-Id: I4496833409b142babc907dff8033da75789c932e Reviewed-on: https://chromium-review.googlesource.com/688058 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#504783} [modify] https://crrev.com/b3e1a0ac9efb9ad51efa77786881bae5ebf64d7d/tools/perf/benchmarks/system_health.py [modify] https://crrev.com/b3e1a0ac9efb9ad51efa77786881bae5ebf64d7d/tools/perf/page_sets/data/system_health_desktop.json [add] https://crrev.com/b3e1a0ac9efb9ad51efa77786881bae5ebf64d7d/tools/perf/page_sets/data/system_health_desktop_059.wprgo.sha1 [add] https://crrev.com/b3e1a0ac9efb9ad51efa77786881bae5ebf64d7d/tools/perf/page_sets/system_health/accessibility_stories.py [modify] https://crrev.com/b3e1a0ac9efb9ad51efa77786881bae5ebf64d7d/tools/perf/page_sets/system_health/story_tags.py [modify] https://crrev.com/b3e1a0ac9efb9ad51efa77786881bae5ebf64d7d/tools/perf/page_sets/system_health/system_health_story.py
,
Oct 6 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Apr 18 2017