Issue metadata
Sign in to add a comment
|
36.9%-456.1% regression in memory.top_10_mobile_stress at 464747:464856 |
||||||||||||||||||||
Issue descriptionGraphs to come.
,
Apr 17 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8982025544688791264
,
Apr 18 2017
=== Auto-CCing suspected CL author aelias@chromium.org === Hi aelias@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : aelias Commit : e678aa49f3fbb21132296a1356239c79d8db276a Date : Fri Apr 14 22:41:04 2017 Subject: Decouple some graphics-related IsLowEndDevice() policies for 1GB devices. Bisect Details Configuration: android_one_perf_bisect Benchmark : system_health.memory_mobile Metric : memory:chrome:all_processes:reported_by_chrome:gpu:effective_size_avg/browse_media/browse_media_imgur Change : 456.07% | 459832.0 -> 2556984.0 Revision Result N chromium@464807 459832 +- 0.0 6 good chromium@464811 459832 +- 0.0 6 good chromium@464812 459832 +- 0.0 6 good chromium@464813 2556984 +- 0.0 6 bad <-- chromium@464814 2556984 +- 0.0 6 bad chromium@464820 2556984 +- 0.0 6 bad chromium@464832 2556984 +- 0.0 6 bad chromium@464856 2556984 +- 0.0 6 bad Please refer to the following doc on diagnosing memory regressions: https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.media.imgur system_health.memory_mobile Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8982025544688791264 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5889093403148288 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Apr 18 2017
This is a media-related benchmark, and this patch reverted a portion of https://codereview.chromium.org/2333983002 and indeed the memory returns to exactly the level that it was in September 2016. This change is also associated with a media-related usability improvement (they autoplay) so the memory is not simply being wasted. So I'll WontFix as working as intended. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by benhenry@google.com
, Apr 17 2017