New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 712377 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocked on:
issue 704155

Blocking:
issue 634542



Sign in to add a comment

Color managed canvas color conversion tolerance

Project Member Reported by zakerinasab@chromium.org, Apr 17 2017

Issue description


In https://codereview.chromium.org/2797213002/ we set the tolerance level for color conversion test in color managed canvas (see CanvasRenderingContext2DTest::ColorManagedPutImageDataOn...) for linear SRGB, P3 and Rec2020 to 0.15, 0.1, and 0.1, respectively. These numbers are higher than expected (I would like < 0.001). We should try to find the source of this inaccuracy and see if it can be resolved.
 
Blockedon: 704155
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d1446afeba33daffa3b2e68acf827bf4cf8ad21

commit 7d1446afeba33daffa3b2e68acf827bf4cf8ad21
Author: Reza.Zakerinasab <zakerinasab@chromium.org>
Date: Tue Jun 13 14:09:57 2017

Fix color conversion tolerance in CanvasRenderingContext2DTest

This CL resets the color conversion tolernace in CanvasRenderingContext2DTest
to 0.01 from the previous values (0.1-0.15).

Bug:  712377 
Change-Id: I1df931b46642c9b70d726413d4b7711c4421fcfe
Reviewed-on: https://chromium-review.googlesource.com/531631
Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479005}
[modify] https://crrev.com/7d1446afeba33daffa3b2e68acf827bf4cf8ad21/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp

Status: Fixed (was: Assigned)
Blocking: 634542

Sign in to add a comment